[HOLD for payment 2023-10-02] [$1000] Create a lint rule for unused styles and translation keys

[luacmartins]

Problem

We often add new styles to styles.js or copy to en.js and es.js, but when we remove the last instance using them in App, sometimes we forget to also remove their definition from en.js, es.js or styles.js.

Why is this important

Keeps the codebase clean

Solution

Add a lint rule to eslint-config-expensify to catch unused styles and translation keys so we can remove them appropriately.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0140cfa1480a9e4861
• Upwork Job ID: 1676651464070823936
• Last Price Increase: 2023-07-05

[melvin-bot]

Triggered auto assignment to @NicMendonca (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[luacmartins]

No design changes here. Unassigning @shawnborton

[gedu]

Hey, I am Edu from Callstack - an expert contributor group.

I can work on this one

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0140cfa1480a9e4861

[melvin-bot]

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[gedu]

Working on handling deep storage per key, and searching

[gedu]

Working on reading the styles and translation files, and adding tests compatible with JSX

[gedu]

Need to work on another issue, couldn't work on it today

[NicMendonca]

@gedu any update here?

[luacmartins]

That's awesome! Great work!

[luacmartins]

@gedu is still working on the PR

[gedu]

I'm currently resolving the conflicts, and I've added some comments to the PR. However, due to the new style format that incorporates a Theme object, I need to modify the way we retrieve and integrate these styles within the codebase.

[luacmartins]

PR is still being worked on as per @gedu's update above

[gedu]

@luacmartins PR updated, also found another unused style because a component was removed, so it is working great

[luacmartins]

Awesome! Is the PR ready for review?

[gedu]

@luacmartins Yes it is 🙌

[gedu]

@luacmartins Comments fixed and conflicts solved

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Unused styles translation script #26969

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @gedu does not require payment (Contractor)
• @fedirjh requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[NicMendonca]

• reporter: N/A
• Contributor: @gedu (does not require payment)
• C+ @fedirjh -- @fedirjh sorry if this is dim, but it doesn't look like you ended up reviewing this PR, is that correct?

[luacmartins]

@NicMendonca correct, @fedirjh did not review that PR.

[NicMendonca]

ok cool, we're all set here then!