Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Web - When hovering over the message in the reply thread, the icon changes its position in the Task Assign section. #22297

Closed
1 of 6 tasks
kbecciv opened this issue Jul 5, 2023 · 14 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Jul 5, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click on the Plus button.
  2. Go to Task Assign.
  3. Add a title, assign and share information, and confirm tasks.
  4. Write a message and hover over it.
  5. Click on "reply thread" and write a message.
  6. Hover over the message in the reply thread.

Expected Result:

The position of the icon should remain unchanged when hovering over a message in the reply thread.

Actual Result:

When hovering over the message in the reply thread, the icon changes its position in the Task Assign section.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.37-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-capture.91.mp4
Recording.3431.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688581881998149

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b8f2af3b67caa455
  • Upwork Job ID: 1676692535250608128
  • Last Price Increase: 2023-07-05
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2023

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jul 5, 2023
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jul 5, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Jul 5, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2023

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@thienlnam thienlnam removed the DeployBlockerCash This issue or pull request should block deployment label Jul 5, 2023
@thienlnam
Copy link
Contributor

Removing the blocker since it doesn't look like an issue that should block deploy

@thienlnam thienlnam added Daily KSv2 and removed Hourly KSv2 labels Jul 5, 2023
@hayata-suenaga hayata-suenaga added the External Added to denote the issue can be worked on by a contributor label Jul 5, 2023
@melvin-bot melvin-bot bot changed the title Web - When hovering over the message in the reply thread, the icon changes its position in the Task Assign section. [$1000] Web - When hovering over the message in the reply thread, the icon changes its position in the Task Assign section. Jul 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01b8f2af3b67caa455

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2023

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

@olexyt
Copy link
Contributor

olexyt commented Jul 5, 2023

It is still opened for proposal?

@alexxxwork
Copy link
Contributor

Couldn't reproduce. I just don't have "mark as offensive" icon.

@joh42
Copy link
Contributor

joh42 commented Jul 6, 2023

Also unable to reproduce both locally and on staging. Seems like the flag icon is erroneously shown on your own messages, but is then (correctly) removed

@melvin-bot melvin-bot bot added the Overdue label Jul 7, 2023
@lschurr
Copy link
Contributor

lschurr commented Jul 7, 2023

@hayata-suenaga are you able to reproduce this or can it be closed?

@melvin-bot melvin-bot bot removed the Overdue label Jul 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 7, 2023
@lschurr lschurr removed the Overdue label Jul 7, 2023
@abdulrahuman5196
Copy link
Contributor

@lschurr I am unable to reproduce this issue even in staging. If you are also unable to reproduce. We should close this one.

@lschurr
Copy link
Contributor

lschurr commented Jul 10, 2023

Closing.

@lschurr lschurr closed this as completed Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

9 participants