[HOLD for payment 2023-07-26] [$1000] Dev: Web - Console error on click of Connect online with Plaid button

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create workspace if not created
2. Go to settings > Workspaces >Connect bank account
3. Click on Connect online with Plaid button

Expected Result:

Should not show any console error

Actual Result:

Multiple console error appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.37-6
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-07.at.3.38.44.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688724565368739

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01422f8298b6001281
• Upwork Job ID: 1677488790826577920
• Last Price Increase: 2023-07-08

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console error when connecting plaid

What is the root cause of that problem?

We're not wrapping the BankAccountPlaidStep component inside the withLocalize HoC and instead we are using the useLocalize hook. Despite this, we are still using the props that get injected only when using the HoC.

What changes do you think we should make in order to solve the problem?

We should remove the withLocalizePropTypes from the props.

What alternative solutions did you explore? (Optional)

We should wrap the BankAccountPlaidStep component inside the withLocalize Hoc and remove the usage of useLocalize hook.

[greg-schroeder]

I can't reproduce this ... I think it's Dev only? Will ask C+ to help

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01422f8298b6001281

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[greg-schroeder]

Oh hey @allroundexperts - you already have a proposal for this 😅 - I can't reproduce it but I'm assuming you have? Also what's the protocol for accepting your own proposal if you get assigned to an issue as C+ after creating a proposal? lol not sure I've seen that before

[allroundexperts]

Oh hey @allroundexperts - you already have a proposal for this 😅 - I can't reproduce it but I'm assuming you have? Also what's the protocol for accepting your own proposal if you get assigned to an issue as C+ after creating a proposal? lol not sure I've seen that before

HAHAHAHA, My proposal looks good to me. That's lit 🔥🔥🔥

Jokes apart, this is actually a regression from #21778. Since the mentioned PR is within the 7 days regression period, the related C+ and contributor will fix this.

[Vishrut19]

I can reproduce this error and I can see a lot of errors in console.

Screen.Recording.2023-07-09.at.10.17.07.AM.mp4

All these are saying as required - translate, numberFormat, datetimeToRelative etc. all are stated as required but still not passed. So, I think as stated by @allroundexperts with we remove withLocalizePropTypes and use use useLocalizethen it should solve all the problems as when I was migrating BankAccountManualStep.js file I saw all these same errors but after removing withLocalize HOC and replacing it with useLocalize hooks along with removing the extra prop types as well using ..._.omit(StepPropTypes, _.keys(withLocalizePropTypes)) which are not required.

[melvin-bot]

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@greg-schroeder, @allroundexperts, @hayata-suenaga Huh... This is 4 days overdue. Who can take care of this?

[hayata-suenaga]

wait i'm confused here so @allroundexperts are you already working on the fix PR?

[allroundexperts]

wait i'm confused here so @allroundexperts are you already working on the fix PR?

Not really. What makes you think so?

[hayata-suenaga]

HAHAHAHA, My proposal looks good to me. That's lit 🔥🔥🔥

haha, then I read this

regression from #21778. Since the mentioned PR is within the 7 days regression period, the related C+ and contributor will fix this.

so is this already handled by the PR author or we have to assign the contributor to this?

[allroundexperts]

Oh. This is already handled by the PR author here.

[hayata-suenaga]

ah I see then this issue will be automatically closed when the PR is deployed

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: console error on click of connect online with plaid button #22473

If no regressions arise, payment will be issued on 2023-07-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

Okay so this was a regression and is being handled here (payments, etc.): #16242

[gadhiyamanan]

@greg-schroeder i think reporting bonus should be done here, right?

[greg-schroeder]

Ye, but the C/C+ are in the other issue. You have an offer for reporting in Upwork.

[gadhiyamanan]

You have an offer for reporting in Upwork.

@greg-schroeder i do not have any offer for reporting

[greg-schroeder]

Woops, I sent it the wrong person. Fixed.

[gadhiyamanan]

@greg-schroeder offer Accepted, Thanks!