Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Search string in WorkspaceMembersPage is lost when moving to another page and coming back #22535

Closed
1 of 6 tasks
kbecciv opened this issue Jul 9, 2023 · 7 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 NewFeature Something to build that is a new item.

Comments

@kbecciv
Copy link

kbecciv commented Jul 9, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to settings
  2. Click on workspaces
  3. Click on a workspace
  4. Click on Members
  5. Search for a string, click on invite.
  6. Click back and find that search field is empty.

Expected Result:

Search field should persist when navigating back to Members page from Invite page

Actual Result:

Search field becomes empty

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.38-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-09.at.3.17.27.PM.mov
Recording.3521.mp4

Expensify/Expensify Issue URL:
Issue reported by: @c3024
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688896241730799

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 NewFeature Something to build that is a new item. Bug Something is broken. Auto assigns a BugZero manager. labels Jul 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 9, 2023

@melvin-bot melvin-bot bot added the Weekly KSv2 label Jul 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 9, 2023

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Daily KSv2 Weekly KSv2 labels Jul 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 9, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link

melvin-bot bot commented Jul 9, 2023

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@kbecciv
Copy link
Author

kbecciv commented Jul 9, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search string is lost when clicking on Invite members from WorkspaceMembersPage and coming back to WorkspaceMembersPage

What is the root cause of that problem?

When we are navgiating to Invite page, we are setting searchValue as '' in WorkspaceMembersPage

const inviteUser = () => {
        setSearchValue('');

so it is lost.

What changes do you think we should make in order to solve the problem?

We should remove the setSearchValue line above

What alternative solutions did you explore? (Optional)

@shawnborton
Copy link
Contributor

This feels like a dupe of #22534

So I think we should just close this one out.

@isabelastisser
Copy link
Contributor

dupe, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

4 participants