Web – Announce Room - Inconsistency among title of “Notify me”.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any "announce room."
2. Navigate to the "Details" section.
3. Click on "Settings."
4. Open any option, such as "Who can post" or "Welcome Message," to observe that the title remains consistent when the option is selected.
5. Click on "Notify me" and observe the discrepancy in the title.
6. In the settings, the title is displayed as "Notify me about new messages," but when clicked, the title changes to "Notification preferences."

Expected Result:

The title of the "Notify me" feature should remain consistent with other pages to ensure uniformity and user familiarity.

Actual Result:

The title of the "Notify me" feature is not consistent with other pages, causing confusion and potential user frustration.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.38-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

1.1.mp4

Recording.3532.mp4

Expensify/Expensify Issue URL:
Issue reported by: @usmantariq96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688969057592269

View all open jobs on GitHub

[GItGudRatio]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The title of the "Notify me" feature is not consistent with other pages, causing confusion and potential user frustration.

What is the root cause of that problem?

The root cause lies in product decision, we decided to implement this like this.

What changes do you think we should make in order to solve the problem?

To solve this issue, we can use notificationPreferencesPage.header instead of notificationPreferencesPage.label:

App/src/pages/settings/Report/ReportSettingsPage.js

Line 118 in ab37414

description={this.props.translate('notificationPreferencesPage.label')}

This will ensure consistency among header and title. Now, in addition to this, to better explain the use of this feature, we can add a text component above the OptionsList that will explain these changes. We can re word notificationPreferencesPage.label that will better explain the notification feature.

What alternative solutions did you explore? (Optional)

We can wait for #22553 to be implemented before proceeding with the mentioned solution.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The title of the "Notify me" feature should remain consistent with other pages to ensure uniformity and user familiarity.

What is the root cause of that problem?

The title of the header being passed in is being different from the option is selected

App/src/pages/settings/Report/NotificationPreferencePage.js

Line 41 in ab37414

title={props.translate('notificationPreferencesPage.header')}

What changes do you think we should make in order to solve the problem?

1. We need a shared update use header use notificationPreferencesPage.label
2. Remove translation: notificationPreferencesPage.header

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

📣 @mudassar69! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

📣 @Muhammad-Bilal-7896! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Christinadobrzyn]

I think this is a feature request, I don't think that the name of the setting being inconsistent with other settings is a bug - but I'll check with the team once I have confirmation of what we're expecting from the reporter - https://expensify.slack.com/archives/C049HHMV9SM/p1689032300429379?thread_ts=1688969057.592269&cid=C049HHMV9SM

[Christinadobrzyn]

asking the team here - https://expensify.slack.com/archives/C01SKUP7QR0/p1689109579107509

[Christinadobrzyn]

Discussed this with the team - not a bug. feel free to propose this as a feature request if you think it's important to change.