NEWDOT PAYMENT DUE [HOLD for payment 2023-08-17] Add an option for distance requests

[neil-marcellini]

Please follow the plan in the design doc.

[melvin-bot]

Huh... This is 4 days overdue. Who can take care of this?

[neil-marcellini]

I got a draft PR up which is branched off the changes in progress for Scan Receipt. I think I'm almost done with it, but I still need to create the empty optimistic transaction object and set it's ID on the IOU object.

[neil-marcellini]

PR is up for review, but held on the PR for scan receipt.

[neil-marcellini]

Under review, waiting for C+.

[neil-marcellini]

PR just merged!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[neil-marcellini]

That blocker was invalid.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add an option for distance requests #23048

If no regressions arise, payment will be issued on 2023-08-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[allroundexperts]

I reviewed the PR for this. Bumping for the payment summary.

[neil-marcellini]

Oooh let me assign someone who can handle payment.

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[neil-marcellini]

@sophiepintoraetz would you please pay the C+ @allroundexperts who reviewed my PR?

[sophiepintoraetz]

Payouts due:

Contributor: $1000 @allroundexperts

Eligible for 50% #urgency bonus? N - this is a flat review

[sophiepintoraetz]

@JmillsExpensify - bump for the ND payment - @allroundexperts can you raise a request, please?

[allroundexperts]

Request raised!

[JmillsExpensify]

Reviewed the details for @allroundexperts. $1,000 payment approved via NewDot based on BZ summary.