[HOLD for payment 2023-10-24] [ECard Settings] - Add Assigned Card tile & Display Expensify cards

[grgia]

HOLD ON https://github.com/Expensify/Expensify/issues/299923

Design Doc Section

https://docs.google.com/document/d/1rFxJ78vz5On6zSWzYa51B9v-tyLdC5pUsBeLOLig0t4/edit#bookmark=id.39u16xejrb8c

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ab3350fcd013bf5f
• Upwork Job ID: 1679789970416893952
• Last Price Increase: 2023-07-14

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ab3350fcd013bf5f

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

[grgia]

cc @pac-guerreiro

[pac-guerreiro]

Could you assign me to this @grgia ? 😄

[marcaaron]

I think this one actually can be off HOLD or at least split into two parts. There won't be any cards appearing until the API changes are merged and we start using these components on the "Wallet" page. But we could build most of the UI with mock data.

Maybe we can get started building out the Assigned cards tile component and add a story for it in Storybook.

@pac-guerreiro does an approach like that work for you?

[marcaaron]

I don't think we want to switch over to the new page until the Expensify Cards are actually showing up. But we could also start reviewing and testing the changes so they are ready to ship as soon as the API changes are deployed.

[marcaaron]

I'm gonna remove the HOLD on the issue so we can get started. But I'd recommend to put a hold on the PR so it doesn't get accidentally deployed before the API changes.

[melvin-bot]

@pac-guerreiro, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[pac-guerreiro]

@marcaaron the approach you mentioned makes sense to me!

[melvin-bot]

This issue has not been updated in over 15 days. @pac-guerreiro, @thesahindia eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[joekaufmanexpensify]

@akinwale is going to jumping in on this one to help with testing. This should help the review go faster since this is a large PR.

[joekaufmanexpensify]

@allroundexperts as an fyi I just confirmed this is officially ready for a re-review

[grgia]

@joekaufmanexpensify can you help to make sure that both @allroundexperts and @rushatgabhane get C+ payments

[joekaufmanexpensify]

yes!

[joekaufmanexpensify]

Bumping to weekly so I can handle payments once PR has been on prod for 7 days next week

[rushatgabhane]

created a manual request https://staging.new.expensify.com/r/2769532492131836

[allroundexperts]

Created a manual request as well.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Feature/add assigned card tile and display expensify cards #26862

If no regressions arise, payment will be issued on 2023-10-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rushatgabhane does not require payment (Eligible for Manual Requests)
• @allroundexperts does not require payment (Eligible for Manual Requests)
• @pac-guerreiro does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[joekaufmanexpensify]

Payment summary:

• @allroundexperts $500 for C+ review on internal PR.
• @rushatgabhane $500 for C+ review on internal PR.

[JmillsExpensify]

$500 payment approved for @rushatgabhane based on BZ summary.

[joekaufmanexpensify]

Confirming second payment was issued too

[joekaufmanexpensify]

Okay, chatted with Jason and confirmed @allroundexperts payment is still pending being issued. Closing this as payment has been requested.

[JmillsExpensify]

$500 payment approved for @allroundexperts based on summary above.