Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECard Settings] - Add “Report card lost or damaged” page and route #22879

Closed
grgia opened this issue Jul 14, 2023 · 34 comments
Closed

[ECard Settings] - Add “Report card lost or damaged” page and route #22879

grgia opened this issue Jul 14, 2023 · 34 comments
Assignees
@grgia @JKobrynski
Labels
Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@grgia
Copy link
Contributor

grgia commented Jul 14, 2023 •
edited by melvin-bot bot
Loading

HOLD ON #22873

Design Doc Section

https://docs.google.com/document/d/1rFxJ78vz5On6zSWzYa51B9v-tyLdC5pUsBeLOLig0t4/edit#bookmark=id.pzrikt6apuww

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b1fc285f24bcb4a2
  • Upwork Job ID: 1679791944763441152
  • Last Price Increase: 2023-07-14
@grgia grgia added the Internal Requires API changes or must be handled by Expensify staff label Jul 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01b1fc285f24bcb4a2

@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

@melvin-bot melvin-bot bot added the Monthly KSv2 label Jul 17, 2023
@grgia
Copy link
Contributor Author

grgia commented Aug 31, 2023

cc @pac-guerreiro

@melvin-bot melvin-bot bot added the Overdue label Aug 31, 2023
@pac-guerreiro
Copy link
Contributor

Could you assign me to this @grgia ? 😄

@marcaaron
Copy link
Contributor

Similarly, I think this can come off hold. We won't be able to navigate to this page in product until the Expensify Card page exists. And we won't be able to call the API until that change is done (maybe it's done). But we can for sure start creating this page now I think.

@marcaaron marcaaron added Daily KSv2 and removed Monthly KSv2 labels Aug 31, 2023
@melvin-bot melvin-bot bot removed the Overdue label Aug 31, 2023
@marcaaron marcaaron changed the title [HOLD #22873][ECard Settings] - Add “Report card lost or damaged” page and route [ECard Settings] - Add “Report card lost or damaged” page and route Aug 31, 2023
@marcaaron
Copy link
Contributor

Same sentiments here. We can create this page without having the page to navigate to and get something rolling. This whole project is mostly UI so we can build it all. Nobody will be able to access it or use it until the API is ready, but shouldn't block us from building it out.

@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

@parasharrajat, @pac-guerreiro Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2023
@JKobrynski
Copy link
Contributor

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue.

@melvin-bot melvin-bot bot removed the Overdue label Sep 5, 2023
@parasharrajat
Copy link
Member

Requested access to design doc to be able to review the PR.

@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@parasharrajat, @JKobrynski Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@parasharrajat, @JKobrynski Eep! 4 days overdue now. Issues have feelings too...

@parasharrajat
Copy link
Member

Awaiting PR.

@melvin-bot melvin-bot bot removed the Overdue label Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2023

@parasharrajat, @JKobrynski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Sep 15, 2023
@parasharrajat
Copy link
Member

Awaiting PR.

@melvin-bot melvin-bot bot added the Overdue label Sep 29, 2023
@grgia
Copy link
Contributor Author

grgia commented Oct 2, 2023

not overdue, in progress

@melvin-bot melvin-bot bot removed the Overdue label Oct 2, 2023
@joekaufmanexpensify
Copy link
Contributor

@allroundexperts I see you're taking this over. Could you please confirm if you can review today? We'd like to make progress on this asap.

@allroundexperts
Copy link
Contributor

@joekaufmanexpensify Yes. I should be able to review it tonight (my time)

@joekaufmanexpensify
Copy link
Contributor

Great, ty!

@melvin-bot melvin-bot bot added the Overdue label Oct 4, 2023
@grgia
Copy link
Contributor Author

grgia commented Oct 4, 2023

in progress

@melvin-bot melvin-bot bot removed the Overdue label Oct 4, 2023
@parasharrajat parasharrajat removed their assignment Oct 5, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 10, 2023

@grgia, @JKobrynski Eep! 4 days overdue now. Issues have feelings too...

@joekaufmanexpensify
Copy link
Contributor

@allroundexperts as an fyi, looks like this one is ready for re-review!

@allroundexperts
Copy link
Contributor

@joekaufmanexpensify I'm actively reviewing it.

@joekaufmanexpensify
Copy link
Contributor

Great, ty!

@grgia
Copy link
Contributor Author

grgia commented Oct 11, 2023

in progress

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

@grgia, @JKobrynski Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

@grgia, @JKobrynski Still overdue 6 days?! Let's take care of this!

@grgia
Copy link
Contributor Author

grgia commented Oct 18, 2023

in progress

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 18, 2023
@grgia
Copy link
Contributor Author

grgia commented Oct 24, 2023

PR merged

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2023

@grgia, @JKobrynski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Oct 31, 2023

@grgia, @JKobrynski Still overdue 6 days?! Let's take care of this!

@grgia grgia closed this as completed Oct 31, 2023
@melvin-bot melvin-bot bot removed the Overdue label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grgia grgia

@JKobrynski JKobrynski

Labels
Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@parasharrajat @allroundexperts @marcaaron @grgia @JKobrynski @pac-guerreiro @joekaufmanexpensify