Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [ECard Settings] - Add “Report virtual card fraud” page and route #22880

Closed
grgia opened this issue Jul 14, 2023 · 34 comments
Closed

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [ECard Settings] - Add “Report virtual card fraud” page and route #22880

grgia opened this issue Jul 14, 2023 · 34 comments
Assignees
@s77rt @pasyukevich @grgia @joekaufmanexpensify
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@grgia
Copy link
Contributor

grgia commented Jul 14, 2023 •
edited by melvin-bot bot
Loading

HOLD ON #22873

Design Doc Section

https://docs.google.com/document/d/1rFxJ78vz5On6zSWzYa51B9v-tyLdC5pUsBeLOLig0t4/edit#bookmark=id.q9y9t2vy090m

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017ab90cdfe61c6886
  • Upwork Job ID: 1679792079779143680
  • Last Price Increase: 2023-07-14
@grgia grgia added the Internal Requires API changes or must be handled by Expensify staff label Jul 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

Job added to Upwork: https://www.upwork.com/jobs/~017ab90cdfe61c6886

@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

@melvin-bot melvin-bot bot added the Monthly KSv2 label Jul 17, 2023
@grgia grgia changed the title [HOLD #22873][ECard Settings] - Add “Report digital card fraud” page and route [HOLD #22873][ECard Settings] - Add “Report virtual card fraud” page and route Aug 16, 2023
@grgia
Copy link
Contributor Author

grgia commented Aug 31, 2023

cc @pac-guerreiro

@melvin-bot melvin-bot bot added the Overdue label Aug 31, 2023
@pac-guerreiro
Copy link
Contributor

Could you assign me to this @grgia ? 😄

@marcaaron marcaaron added Daily KSv2 and removed Monthly KSv2 labels Aug 31, 2023
@melvin-bot melvin-bot bot removed the Overdue label Aug 31, 2023
@marcaaron marcaaron changed the title [HOLD #22873][ECard Settings] - Add “Report virtual card fraud” page and route [ECard Settings] - Add “Report virtual card fraud” page and route Aug 31, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

@s77rt, @pac-guerreiro Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2023
@pasyukevich
Copy link
Contributor

Hi!
I'm Eugene from Callstack, an expert contributor group.
I'd like to work on this.

@melvin-bot melvin-bot bot removed the Overdue label Sep 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@s77rt, @pasyukevich Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@s77rt, @pasyukevich Huh... This is 4 days overdue. Who can take care of this?

@s77rt
Copy link
Contributor

s77rt commented Sep 11, 2023

@pasyukevich Any updates here?

@melvin-bot melvin-bot bot removed the Overdue label Sep 11, 2023
@pasyukevich
Copy link
Contributor

@s77rt working on it

@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

@s77rt, @pasyukevich Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Sep 18, 2023
@pasyukevich
Copy link
Contributor

Work in progress. This issue is connected with #22873

@melvin-bot melvin-bot bot removed the Overdue label Sep 18, 2023
@melvin-bot melvin-bot bot added the Weekly KSv2 label Oct 16, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [ECard Settings] - Add “Report virtual card fraud” page and route [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [ECard Settings] - Add “Report virtual card fraud” page and route Oct 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 16, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [ECard Settings] - Add “Report virtual card fraud” page and route [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [ECard Settings] - Add “Report virtual card fraud” page and route Oct 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

@s77rt, @pasyukevich, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

@grgia
Copy link
Contributor Author

grgia commented Oct 24, 2023

not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2023

@s77rt, @pasyukevich, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@grgia
Copy link
Contributor Author

grgia commented Oct 30, 2023

cc @joekaufmanexpensify could you help with $500 C+ review payment to @s77rt

@grgia grgia added the Weekly KSv2 label Oct 30, 2023
@melvin-bot melvin-bot bot removed the Overdue label Oct 30, 2023
@grgia grgia removed the Daily KSv2 label Oct 30, 2023
@joekaufmanexpensify
Copy link
Contributor

yes!

@joekaufmanexpensify joekaufmanexpensify self-assigned this Oct 30, 2023
@joekaufmanexpensify
Copy link
Contributor

joekaufmanexpensify commented Oct 30, 2023 •
edited
Loading

We need to pay @s77rt $500 for their C+ review of this PR. Paid via Upwork.

@s77rt
Copy link
Contributor

s77rt commented Oct 30, 2023

@joekaufmanexpensify I'm still getting paid via Upwork.

@joekaufmanexpensify
Copy link
Contributor

Ah, my bad! I updated my comment above, and will send you an offer now.

@joekaufmanexpensify
Copy link
Contributor

original job was closed, so made a new one: https://www.upwork.com/jobs/~015daf95cf94d7dd28

@joekaufmanexpensify
Copy link
Contributor

@s77rt $500 offer sent via upwork!

@s77rt
Copy link
Contributor

s77rt commented Oct 30, 2023

Accepted! Thanks!

@joekaufmanexpensify
Copy link
Contributor

@s77rt $500 sent and contract ended!

@joekaufmanexpensify
Copy link
Contributor

Closing as payment has been handled!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s77rt s77rt

@pasyukevich pasyukevich

@grgia grgia

@joekaufmanexpensify joekaufmanexpensify

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@s77rt @pasyukevich @marcaaron @grgia @JKobrynski @pac-guerreiro @joekaufmanexpensify