[HOLD for payment 2023-08-08] Dev: Web - Console log error when trying to unlink secondary contact method

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a tab where account A is signed-in
2. Add secondary contact method B, and do not verify that contact method
3. Open a new window > Navigate to sign-in page
4. Enter secondary contact method B & click on the continue button

Expected Result:

There shouldn't be any console log error

Actual Result:

Console log error displayed (ailed prop type: The prop welcomeText is marked as required in SignInPageContent, but its value is undefined.)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.40-5
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-07-14.15-18-03.mp4

Expensify/Expensify Issue URL:
Issue reported by: React JS Developer | Software QA Analyst | GH: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689337434182419

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console warning appears when the unlinking page appears after we login with a secondary login

What is the root cause of that problem?

We are not sending welcomeText in case of shouldShowUnlinkLoginForm here though it is a required prop.
https://github.com/Expensify/App/blob/b9508b616f3a7229365c8bd7280fd1e34cfd2f9b/src/pages/signin/SignInPage.js#L155C5-L162C5

What changes do you think we should make in order to solve the problem?

We should add

welcomeText = isSmallScreenWidth ? translate('welcomeText.welcomeBack') : '';

below the welcomeHeader in the above specified code snippet in RCA there similar to the else statement in the shouldShowResendValidationForm below it.

What alternative solutions did you explore? (Optional)

Since, we are showing Welcome Back as welcomeHeader on large screen on the unlinking page as shouldShowWelcomeHeader is true if isUnvalidatedLogin is true
https://github.com/Expensify/App/blob/b9508b616f3a7229365c8bd7280fd1e34cfd2f9b/src/pages/signin/SignInPage.js#L82C5-L83C1
, we would like to show Welcome Back as welcomeText as well in case of smaller screens but shouldShowWelcomeText does not include isUnvalidatedLogin in its check here
https://github.com/Expensify/App/blob/b9508b616f3a7229365c8bd7280fd1e34cfd2f9b/src/pages/signin/SignInPage.js#L83C5-L84C1
and it returns false.
So we should change the
shouldShowWelcomeText also in line with shouldShowWelcomeHeader like this

const shouldShowWelcomeText = shouldShowLoginForm || shouldShowPasswordForm || shouldShowValidateCodeForm || isUnvalidatedSecondaryLogin || shouldShowEmailDeliveryFailurePage;

Since, we are setting welcomeText to '' explicitly here,
https://github.com/Expensify/App/blob/b9508b616f3a7229365c8bd7280fd1e34cfd2f9b/src/pages/signin/SignInPage.js#L159C1-L161C10
adding shouldShowEmailDelieryFailurePage in the above line has no unexpected effect.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A console error appears when trying to unlink the secondary contact method

What is the root cause of that problem?

When we login with the secondary contact method that is not verified, shouldShowUnlinkLoginForm is true and shouldShowEmailDeliveryFailurePage is false. That makes welcomeText isn't set for this case

App/src/pages/signin/SignInPage.js

Lines 155 to 162 in b9508b6

	} else if (shouldShowUnlinkLoginForm || shouldShowEmailDeliveryFailurePage) {
	welcomeHeader = isSmallScreenWidth ? translate('login.hero.header') : translate('welcomeText.welcomeBack');
	// Don't show any welcome text if we're showing the user the email delivery failed view
	if (shouldShowEmailDeliveryFailurePage) {
	welcomeText = '';
	}
	} else if (!shouldShowResendValidationForm) {

and because we don't set fault value for welcomeText, welcomeText is undefined for this case.

App/src/pages/signin/SignInPage.js

Lines 128 to 129 in b9508b6

	let welcomeHeader;
	let welcomeText;

While welcomeText is required in SignInPageLayout. So console error appears

App/src/pages/signin/SignInPage.js

Line 173 in b9508b6

welcomeText={welcomeText}

What changes do you think we should make in order to solve the problem?

We should set default value for welcomeText and welcomeHeader here to verify that welcomeHeader and welcomeText aren't undefined for all case

let welcomeHeader = '';
let welcomeText = '';

App/src/pages/signin/SignInPage.js

Lines 155 to 162 in b9508b6

	} else if (shouldShowUnlinkLoginForm || shouldShowEmailDeliveryFailurePage) {
	welcomeHeader = isSmallScreenWidth ? translate('login.hero.header') : translate('welcomeText.welcomeBack');
	// Don't show any welcome text if we're showing the user the email delivery failed view
	if (shouldShowEmailDeliveryFailurePage) {
	welcomeText = '';
	}
	} else if (!shouldShowResendValidationForm) {

What alternative solutions did you explore? (Optional)

[melvin-bot]

@sophiepintoraetz Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[sophiepintoraetz]

Hey @MonilBhavsar - assigning you to help with reproducing the console error - as it's in a DEV environment.

[sophiepintoraetz]

Bump for @MonilBhavsar

[MonilBhavsar]

Sorry, I'm able to reproduce the issue. Looking if it's a regression, so we can ask author to fix it.

[MonilBhavsar]

Commented on the PR. Looks like we missed this during Migration from class component to functional component, and is a minor change. Would just push a quick fix and request review from author.

[sophiepintoraetz]

Reporting offer sent - only payment due here seeing as Monil took the fix internally 🙏

[Natnael-Guchima]

Accepted the offer. Thank you.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.48-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix console error when validating/unlinking secondary account #23469

If no regressions arise, payment will be issued on 2023-08-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
• [@MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@MonilBhavsar] Determine if we should create a regression test for this bug.
• [@MonilBhavsar] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sophiepintoraetz]

Payments done!

[0xmiros]

@sophiepintoraetz sorry for late. C+ payment is pending here

[MonilBhavsar]

Reopening to pay c+
0miroslav reviewed PR, so we need to pay them

[sophiepintoraetz]

I see that we have an internal discussion on the best way to pay @0xmiroslav - given that we cannot pay another account

[sophiepintoraetz]

Discussed internally that we cannot pay another account other than to @0xmiroslav - I've sent an offer here!