Settings - Crash when trying to navigate to settings/preferences

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Login with any account
3. On home tab, select profile icon to open settings page
4. Tap on ''Preferences''

Expected Result:

The app should not crash when accessing settings/preferences

Actual Result:

When attempting to access preferences under settings, the web app crashes every time

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.42.6

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6132026_Crash_with_expensifail_account.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Interanal Team

Slack conversation:

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

Seems like this is also related to this PR https://github.com/Expensify/App/pull/21852/files and there is one more blocker tied to it https://github.com/Expensify/App/pull/21852/files

Since there are 2 blockers maybe it would be worth reverting

[pac-guerreiro]

I'm unable to reproduce this on my iPhone 14 Plus, using Safari

[mountiny]

Also coudnt reproduce @lanitochka17 can you reproduce?

[roryabraham]

I am just starting today but would love the opportunity to try to fix the blockers rather than reverting https://github.com/Expensify/App/pull/21852/files

[roryabraham]

What device was this on?

[jasperhuangg]

@roryabraham it looks like it's on mWeb Safari on an actual iOS device

[roryabraham]

I haven't observed this before on my iPhone 14 Pro or any simulators. However, in this PR I discovered that sometimes Lottie was not cleaning up after itself and would leave an invisible animation running in the background forever, which inhibited basic browser APIs such as requestIdleCallback from running as expected.

I'm cautiously optimistic that after we deploy the fix for that this crash may no longer be reproducible

[jasperhuangg]

We are CPing a fix for this, I'll retest this once the CP is on staging

[jasperhuangg]

Retested on staging and this looks like it isn't happening anymore, closing!