Dev: Clicking on user detail page throws the 2 console error

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to ND
2. Navigate to any conversation
3. Press on any receiver name to open their user detail page
4. Notice on console we are getting 2 errors

Expected Result:

no console error should appear

Actual Result:

console error appears

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689644468877559

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dev: Clicking on user detail page throws the 2 console error

What is the root cause of that problem?

In

https://github.com/Expensify/react-native-onyx/blob/a33f6046e5bbd8ee4ec01a9d7c0660565332d861/lib/withOnyx.js#L188

and

App/src/components/withNavigation.js

Line 25 in cc5526b

forwardedRef: PropTypes.oneOfType([PropTypes.func, PropTypes.shape({current: PropTypes.instanceOf(React.Component)})]),

the forwardedRef.current must have the instance of React.Component

But in FloatingActionButtonAndPopover.js we're using useImperativeHandle and return function hideCreateMenu

That why forwardedRef.current of withOnyx and withNavigation is an object, not the instance of React.Component

What changes do you think we should make in order to solve the problem?

In
https://github.com/Expensify/react-native-onyx/blob/a33f6046e5bbd8ee4ec01a9d7c0660565332d861/lib/withOnyx.js#L188

and

App/src/components/withNavigation.js

Line 25 in cc5526b

forwardedRef: PropTypes.oneOfType([PropTypes.func, PropTypes.shape({current: PropTypes.instanceOf(React.Component)})]),

forwardedRef should be changed like the following comment

#20187 (comment)

        forwardedRef: PropTypes.oneOfType([PropTypes.func, PropTypes.shape({current: PropTypes.any})]),

[MitchExpensify]

What exactly are you clicking when you say "Press on any receiver name"? I'm unable to reproduce this so far

[dhairyasenjaliya]

@MitchExpensify its an console error this can be views on Dev

[Santhosh-Sellavel]

@MitchExpensify this is a dupe of #23201

[dhairyasenjaliya]

yeah same RCA this should be closed maybe @tienifr can post their proposal there

[MitchExpensify]

Ah cool, typically I try to reproduce before scouring for dupes! Thanks for the assist @Santhosh-Sellavel & @dhairyasenjaliya 🙇