Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Workspace image change for a second while adding or removing user #23262

Closed
1 of 6 tasks
kbecciv opened this issue Jul 20, 2023 · 11 comments
Closed
1 of 6 tasks

Web - Workspace image change for a second while adding or removing user #23262

kbecciv opened this issue Jul 20, 2023 · 11 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Jul 20, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Create a workspace if not created
  2. Go to Settings > Workspaces > Members
  3. Click on invite button
  4. Invite userB
  5. Check the userB LHN

Expected Result:

Workspace image should not be change

Actual Result:

Workspace image change for a second while adding or removing user

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.43-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-20.at.11.58.19.AM.mov
Recording.3773.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689834584194399

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jul 20, 2023
@kbecciv
Copy link
Author

kbecciv commented Jul 20, 2023

Could be the same root cause of #23189, but correct me if I'm wrong! Thank you

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 20, 2023

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@hannojg
Copy link
Contributor

hannojg commented Jul 20, 2023

Double checking now @kbecciv

@hannojg
Copy link
Contributor

hannojg commented Jul 20, 2023

Hmmmm, I can't reproduce that on main. In general I can tell that the U icon we are seeing, is because somewhere in the code the report name gets read as undefined.
Not sure if its even a bug caused by the PR to be honest.

@amyevans
Copy link
Contributor

I can't repro on main either. Not sure if there's been App code merged since the last deploy to fix it, or maybe there's backend code that's on staging but not production yet 🤔

Continuing to investigate.

@amyevans
Copy link
Contributor

I think it's probably this Web-E PR which separates pusher calls that were previously unified, any thoughts @iwiznia?

@amyevans amyevans added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jul 20, 2023
@amyevans
Copy link
Contributor

Minor bug so not going to block the deploy on it.

@melvin-bot melvin-bot bot added the Overdue label Jul 24, 2023
@amyevans amyevans added the Weekly KSv2 label Jul 25, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jul 25, 2023
@amyevans amyevans removed the Daily KSv2 label Jul 25, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 2, 2023
@amyevans
Copy link
Contributor

amyevans commented Aug 4, 2023

No update

@melvin-bot melvin-bot bot removed the Overdue label Aug 4, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 14, 2023
@amyevans
Copy link
Contributor

No update

@melvin-bot melvin-bot bot removed the Overdue label Aug 15, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 24, 2023
@amyevans
Copy link
Contributor

I don't think this one is worth fixing honestly, so I'm going to just close it

@amyevans amyevans closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2023
@amyevans amyevans removed the Overdue label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants