-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-08-14] [$1000] Tasks assigned disappears from LHN when leaving the chat #23309
Comments
Triggered auto assignment to @anmurali ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.The task assigned to a user disappears from the left-hand navigation (LHN) when the user navigates away from the task chat in focus mode. What is the root cause of that problem?The issue stems from the Lines 2125 to 2183 in 7fea760
What changes do you think we should make in order to solve the problem?To address this issue, we could include a check within the
Result: New.Expensify.-.Google.Chrome.2023-07-21.07-17-49.mp4 |
Rotating the assignment as I am OOO for 10 days |
Triggered auto assignment to @johncschuster ( |
Bug0 Triage Checklist (Main S/O)
|
Job added to Upwork: https://www.upwork.com/jobs/~0120f92e247a863177 |
Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr ( |
Not overdue, Melvin |
ProposalPlease re-state the problem that we are trying to solve in this issue.Tasks assigned disappears from LHN when leaving the chat What is the root cause of that problem?In the focus mode, we have a logic to only show unread chat Lines 2257 to 2260 in 0d876a4
If the report is not either opening or hasDraft or isPinned or waiting iOU action or error. We haven't had a logic to check if current report is a task that has assigned to current user, and this task is not completed yet. What changes do you think we should make in order to solve the problem?I think the condition to show Task in focus mode is not only Task is assigned to current user, but also this Task must not be completed or cancelled yet. It's same condition when we show Green dot indicator for a task in LHN
So my proposal is:
Results: |
Trying to reproduce this error but with no results. Could anyone send a video with the repro steps? Screens from the description are not enough |
Sure New.Expensify.-.Google.Chrome.2023-07-27.19-03-35.mp4 |
@ArekChr let try those steps
|
📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@ArekChr @cristipaval Thanks for accepting my proposal. The PR is ready #23938. Please help me review it. Thanks ❤️ |
🎯 ⚡️ Woah @ArekChr / @hoangzinh, great job pushing this forwards! ⚡️ The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉
On to the next one 🚀 |
@johncschuster @hoangzinh @ArekChr can one of y'all re-test this on staging? QA is reporting that they are still experiencing the bug. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.50-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-08-14. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@puneetlath Re-tested on staging, and no longer expecting this bug. Nagranie.z.ekranu.2023-08-8.o.15.24.59.mov |
Payment to @hoangzinh has been issued! |
@puneetlath do we need to wait on the above checklist to close this out or are we good to go? |
Given that it was a bug that we fixed, I think we should complete the checklist as we always do. |
Regression test proposal:
Do we agree 👍 or 👎 |
I think the only payment is for @hoangzinh. I think we can close the issue, can't we? |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Task is available in LHN
Actual Result:
Task gets disappeared. Tasks that are assigned to me should be pinned in LHN in #focus mode
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689746543712129
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: