[$1000] routing number paste to compose box instead of input field

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. delete all the workspace (if you have any)
2. click on FAB icon
3. select New workspace option
4. which will open RHP
5. go to settings and change the currency to non USD (if currency is USD)
6. click on back button to go previous page
7. click on bank account option which will open workspace currency popup
8. click on update to USD button
9. click on connect manually option
10. paste routing number in input field

Expected Result:

should paste routing number in input field

Actual Result:

routing number paste to compose box

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.42-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-19.at.1.24.21.PM.mov

Recording.1301.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689754408457479

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019ed0e16ea50369c3
• Upwork Job ID: 1682285612094263296
• Last Price Increase: 2023-07-28

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019ed0e16ea50369c3

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

routing number paste to compose box instead of input field

What is the root cause of that problem?

When currency Modal is hidden in Onyx the modal visibility is set to false

What changes do you think we should make in order to solve the problem?

When we open currency modal the RHP modal will always be open so there are going to be two modal on screen. We don't have to set currency modal visibility in onyx.
Add

shouldSetModalVisibility={false}

here

App/src/pages/workspace/WorkspaceInitialPage.js

Line 264 in 8dcad16

<ConfirmModal

What alternative solutions did you explore? (Optional)

We can do the same for other modals in RHP that causes the same problem

[chiragxarora]

Proposal

Please re-state the problem that we are trying to solve in this issue.

routing number paste to compose box instead of input field

What is the root cause of that problem?

Root cause of the issue is that we are using a callback hook to update the currency which we do not need. And that hook depends on the policy object so when we update the policy (by changing default currency), hook rerenders the component itself and causes issues

What changes do you think we should make in order to solve the problem?

We should remove the callback hook and replace it with a simple handler to take care of the currency updates

const confirmCurrencyChangeAndHideModal = () => {
    Policy.updateGeneralSettings(policy.id, policy.name, CONST.CURRENCY.USD);
    setIsCurrencyModalOpen(false);
    ReimbursementAccount.navigateToBankAccountRoute(policy.id);
};

Results

What alternative solutions did you explore? (Optional)

None

[samh-nl]

Same root cause as #23184

[rk111]

I will work on this issue

[laurenreidexpensify]

@abdulrahuman5196 bump for review of these proposals. Thanks

[laurenreidexpensify]

@abdulrahuman5196 bump for review pls :)

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[laurenreidexpensify]

@abdulrahuman5196 bump for review ^^ thanks

[abdulrahuman5196]

Sorry for the delay from my end. Will close out the review today.

[abdulrahuman5196]

@laurenreidexpensify This seems to be a dupe happening at a different place of this issue - #23184
Thanks @samh-nl for pointing it out.

[laurenreidexpensify]

Ah you're right. That one was opened first, so closing in favour of that