Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Clicking the back button opens the Track distance page instead of navigating to the workspace settings #23590

Closed
1 of 6 tasks
kbecciv opened this issue Jul 25, 2023 · 10 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jul 25, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to Settings > Workspaces.
  2. Select a workspace.
  3. Navigate to Reimbursements > Track distance.
  4. Refresh the page and click on Save.
  5. Now, go to Connect bank account.
  6. Press the back button to return to the workspace settings.
  7. Notice that it opens the Track distance page instead of going back to workspace settings.

Expected Result:

When clicking the back button, the user should be taken back to the workspace settings instead of the Track distance page

Actual Result:

Clicking the back button opens the Track distance page instead of navigating to the workspace settings

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-07-24-at-114146-pm_c9eRvqnL.mp4
Recording.3906.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690224906176959

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 25, 2023

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 25, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@ginsuma

This comment was marked as outdated.

@bernhardoj
Copy link
Contributor

Being handled here #22789

@ayazhussain79
Copy link
Contributor

@bernhardoj You didn't know about this bug before I reported it so now you will fix it in your PR it's not dupe

@bernhardoj
Copy link
Contributor

@ayazhussain79 that's not the case. Your report is yesterday while my PR has been there for 2 weeks. The latest commit (which is merging with main) is 5 days ago.

@ayazhussain79
Copy link
Contributor

@bernhardoj Will see if your PR will fix it which you have changed before this bug

@slafortune
Copy link
Contributor

@ayazhussain79

Syed, I appreciate the effort you put into your work, and I can see the potential you have to contribute. Your communication came across here quite negatively. We believe that a positive and collaborative attitude is essential for our team's success. I wanted to share this feedback with you because I believe in your ability to make positive changes. If there's anything I can do to support you in this process, please let me know ~ Expensify Code of Conduct

If you ever have a question regarding assignment and payment, a good source is our Guidelines here.

@slafortune
Copy link
Contributor

Closing as a dupe

@ayazhussain79
Copy link
Contributor

@slafortune I deeply apologize for the negative tone of my previous message. I am sincerely sorry for any hurt it may have caused

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

5 participants