Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Personal details- Legal last name validation error only after start typing first name #23901

Closed
2 of 6 tasks
kbecciv opened this issue Jul 30, 2023 · 15 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Jul 30, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click on Avatar, go to details
  2. Click personal details go to legal name
  3. Select cursor on first name, don’t type anything
  4. Now go to last name, observe validation error for first name
  5. Don’t type anything in last name and go to first name
  6. Observe validation error is not coming for last name
  7. Start typing in first name,

Expected Result:

Validation should happen as soon as cursor leaves field

Actual Result:

Validation is happening when cursor is on another field and start typing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.47-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1690637319.1.MP4
Recording.4019.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Premsjce
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690637799355469

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f467d1827a62e969
  • Upwork Job ID: 1695736788219748352
  • Last Price Increase: 2023-08-31
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 30, 2023

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 30, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@s-alves10
Copy link
Contributor

Dupe of #23780

@sakluger
Copy link
Contributor

sakluger commented Aug 1, 2023

@s-alves10 thanks for your comment! I doubt I would have found that PR otherwise.

@sakluger sakluger closed this as completed Aug 1, 2023
@kbecciv
Copy link
Author

kbecciv commented Aug 26, 2023

Hey @s-alves10! I think your mentioned the wrong duplicate for this issue, can you please check again,. Thank you in advance.

@kbecciv kbecciv reopened this Aug 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 27, 2023

@sakluger this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Aug 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 27, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01f467d1827a62e969

@melvin-bot
Copy link

melvin-bot bot commented Aug 27, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @situchan (Internal)

@sakluger
Copy link
Contributor

@situchan mind checking if that issue you linked is actually a dupe? Upon closer inspection, it doesn't look like it is.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 28, 2023
@sakluger
Copy link
Contributor

I'm going to add the external label to this one - @situchan let me know if we missed anything and it is actually a duplicate.

@melvin-bot melvin-bot bot removed the Overdue label Aug 31, 2023
@sakluger sakluger added External Added to denote the issue can be worked on by a contributor and removed Internal Requires API changes or must be handled by Expensify staff labels Aug 31, 2023
@melvin-bot melvin-bot bot changed the title Personal details- Legal last name validation error only after start typing first name [$500] Personal details- Legal last name validation error only after start typing first name Aug 31, 2023
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 31, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 31, 2023

Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Aug 31, 2023

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

@napster125
Copy link
Contributor

I can't reproduce this issue.

@situchan
Copy link
Contributor

situchan commented Sep 1, 2023

I am not able to reproduce. Confirming on slack

@situchan
Copy link
Contributor

situchan commented Sep 1, 2023

Confirmed not reproducible by bug reporter.
@sakluger let's close as fixed already

@sakluger sakluger closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants