[HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] Pressing Enter key on Split bill page doesn't navigate to next step

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on 'FAB' menu
2. Click on 'Split bill' button
3. Enter amount & press 'Enter' key

Expected Result:

User should be navigated to the next step

Actual Result:

User is not navigated to the next step

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.48-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-07-31.19.08.32.mp4

Recording.1417.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690829632233769

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[getusha]

@marcaaron did some debugging, i think the root cause of this issue is from onyx, the update of the amount is delayed and initially it's 0 so it will navigate us back from MoneyRequestParticipantsPage here:

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

Lines 77 to 79 in 1fa4b72

	if (props.iou.amount === 0 || shouldReset) {
	navigateBack(true);
	}

and there is onyx version upgrade 5 days ago deployed to staging NoQA] Perf/onyx upgrade use cache directly #23749

[Pujan92]

@hannojg This seems to persist after react-native-onyx change #23749 Expensify/react-native-onyx#280 , cache logic(cahcedState) implementation might be the cause for this. With the earlier version 1.0.52 issue is not reproducible.

Specifically in this case, we don't want to render immediately with the cached data as we depend on the updated one which is still in the execution.
https://github.com/Expensify/react-native-onyx/pull/280/files#diff-364fd7349a1af7b52091427c5a0734da8ff56057fbc7fe2be10734a06c97264cR52-R53

[getusha]

@Pujan92 what a coincidence! 😄

[marcaaron]

@Pujan92 what a coincidence! 😄

@getusha Is that sarcasm? If so, not sure if I understood you properly or what the "coincidence" you are referring to is. Thanks!

[getusha]

@getusha Is that sarcasm? If so, not sure if I understood you properly or what the "coincidence" you are referring to is. Thanks!

@marcaaron It's just the fact that @Pujan92 and i commented almost the exact same time.

[hannojg]

I am currently running into an issue where I can't open the split bill page due to this crash. is it just me or everyone?

[hannojg]

Try creating a new fresh account in a new browser instance. I think the crash is reproducible

[parasharrajat]

Yes, it happening to all.

[Beamanator]

Ya that looks like this issue: #23951 (aah looks like you found it already)

[hannojg]

Okay, however with these changes, there is still the issue that when pressing the Enter-Key,

1. You will open a second instance of the same page (split bill)
2. On the second press you get to the next page

There was a separate issue for that, not sure if that's also due to the onyx changes will double check!

[hannojg]

• [HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] [$1000] IOU - Double "request money" tab if request money #23962

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[hannojg]

Fixed also with this PR:

• Wait for onyx operations to complete before opening new screen #23996

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.48-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] [Revert] Perf/onyx upgrade use cache directly #24003

If no regressions arise, payment will be issued on 2023-08-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@marcaaron] The PR that introduced the bug has been identified. Link to the PR:
• [@marcaaron] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@marcaaron] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@marcaaron] Determine if we should create a regression test for this bug.
• [@marcaaron] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.49-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] [Revert] Perf/onyx upgrade use cache directly #24003

If no regressions arise, payment will be issued on 2023-08-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[Natnael-Guchima]

Hello @marcaaron, no reporting bonus is issued here.

[Natnael-Guchima]

A gentle bump for reporting payment @isabelastisser

[isabelastisser]

@Natnael-Guchima I sent you an offer in Upwork now. Please accept it and I will process the payment. Thanks!

[Natnael-Guchima]

I have accepted the offer. Thanks @isabelastisser