[HOLD for payment 2023-08-16] User can't click on header to open detail of public room

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a public room from account A.
2. Copy url of that public room and paste the browser where account B is logged in
3. Notice that user B can't click on header or avatar of that room to open Detail page.

Expected Result:

User should be able to open detail page of that room

Actual Result:

User can't be able to open detail page of that room

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.50-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Uploading 258138799-26e8b1db-fd4b-4357-9d2e-bbdca014bc5a.mov…

Recording.1437.mp4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691038592033389

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[StevenKKC]

Seems like PR #23802 introduce this issue.

https://github.com/Expensify/App/pull/23802/files#diff-33715f93ff5ed9b567fc20382dadef0bddb41c82e58c356d28b6cc5eee9906c9

[dukenv0307]

Proposal

Please re-state the pr0oblem that we are trying to solve in this issue.

User can't click on header to open detail of public room

What is the root cause of that problem?

shouldDisableDetailPage function doesn't return false for chat room

App/src/libs/ReportUtils.js

Line 413 in d051341

function shouldDisableDetailPage(report) {

What changes do you think we should make in order to solve the problem?

Because we should disable user to go to profile page when clicking on header of a DM report if the user is an optimistic user, we should follow navigateToDetailsPage function and then only return isOptimisticPersonalDetail(participantAccounsIDs[0]) for the case participantAccountIDs.length === 1

const participantAccountIDs = lodashGet(report, 'participantAccountIDs', []);

if (isChatRoom(report) || isPolicyExpenseChat(report) || isChatThread(report)) {
    return false;
}
if (participantAccountIDs.length === 1) {
    return isOptimisticPersonalDetail(participantAccountIDs[0]);
}
return false;

What alternative solutions did you explore? (Optional)

[hungvu193]

Seems like PR #23802 introduce this issue.

https://github.com/Expensify/App/pull/23802/files#diff-33715f93ff5ed9b567fc20382dadef0bddb41c82e58c356d28b6cc5eee9906c9

Yeah you're right

[sobitneupane]

We are working on the fix in this PR.

[Beamanator]

Fix is on staging!

[Julesssss]

Just noting this was marked as a regression of this issue.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix user cannot open detail page of chat room #24091

If no regressions arise, payment will be issued on 2023-08-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@deetergp] The PR that introduced the bug has been identified. Link to the PR: Disable go to profile page for optimistic user #23802
• [@deetergp] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Disable go to profile page for optimistic user #23802 (comment)
• [@deetergp] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1691038592033389
• [@deetergp] Determine if we should create a regression test for this bug.
• [@deetergp] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[deetergp]

Do we feel we need a new regression test to prevent this from occurring again in the future?

[adelekennedy]

not much traction here - I'm going to pay out @hungvu193 the reporting bonus and close this out

[adelekennedy]

Payouts due:

Issue Reporter: $250 @hungvu193

Eligible for 50% #urgency bonus? N

Upwork job is here.