[HOLD for payment 2023-08-16] Profile - Zoom and rotate button doesn't work for uploading avatar image

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to Settings -> Profile -> Upload photo -> Choose any image
4. Try zooming or rotating the selected image

Expected Result:

You have a possibility to zoom and rotate selected image

Actual Result:

Zoom and rotate button doesn't work. Error appears after saving image
WS avatar - the same

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.50.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6152148_Recording__5720.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[luacmartins]

Looking into this now

[luacmartins]

This is coming from the update to react-native-gesture-handler and the context argument being an empty object. I left a comment here since SWM is the maintainer of the library.

[luacmartins]

I think we have a couple of options here:

1. Revert the react-native-gesture-handler version bump from 2.9.0 to 2.12.0, which fixes this particular issue, but I'm not sure what other issues that might cause since we updated RN to 0.72.1.
2. Wait for SWM to reply to my thread tomorrow and go from there.

@Beamanator I'll be ooo tomorrow and Monday though so we'll have to find a volunteer to take this on.

[shubham1206agra]

I think we have a couple of options here:

1. Revert the react-native-gesture-handler version bump from 2.9.0 to 2.12.0, which fixes this particular issue, but I'm not sure what other issues that might cause since we updated RN to 0.72.1.
2. Wait for SWM to reply to my thread tomorrow and go from there.

@Beamanator I'll be ooo tomorrow and Monday though so we'll have to find a volunteer to take this on.

Can't we just try to create a local patch for now?

[Beamanator]

SWM helped make a PR to use old implementation that works for us, here: https://github.com/Expensify/App/pull/24152/files

[Beamanator]

PR on staging and working well, no longer a blocker!

we can probably close this b/c the PR creator was SWM!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Use legacy web implementation of Gesture Handler #24152

If no regressions arise, payment will be issued on 2023-08-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty