[HOLD for payment 2023-09-15] [$1000] Android - Request money - Different app behavior when asking for camera permission in Scan receipt

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat
3. Tap + button > Add attachments > Take photo
4. Return to LHN
5. Click + button > Request Money > Scan
6. Tap on the capture button

Expected Result:

The app should ask for camera permission the same way it asks for permission when adding attachments by taking photo

Actual Result:

In Step 3, the app asks for camera permission via pop-up
In Step 6, the app shows error message when tapping on the capture button. User is required to go to app settings to manually allow camera permission via Give permission CTA

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.50.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6153015_Screen_Recording_20230804_035156_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0142d61bc15de5a06b
• Upwork Job ID: 1687482269732622336
• Last Price Increase: 2023-08-24
• Automatic offers:
• tienifr | Contributor | 26331513

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Beamanator]

Receipt scanning is under beta so not a deploy blocker - but @AndrewGable it looks like this is something you've been working on recently, maybe you can take over for max?

[hungvu193]

We're opening the setting here instead of request the permission for Android:

App/src/pages/iou/ReceiptSelector/index.native.js

Line 134 in d4cd138

onPress: () => Linking.openSettings(),

I think we should use request permission for camera instead of open setting:

App/src/components/AttachmentPicker/launchCamera.android.js

Lines 12 to 32 in d4cd138

	export default function launchCameraAndroid(options, callback) {
	// Checks current camera permissions and prompts the user in case they aren't granted
	PermissionsAndroid.request(PermissionsAndroid.PERMISSIONS.CAMERA)
	.then((permission) => {
	if (permission !== PermissionsAndroid.RESULTS.GRANTED) {
	const error = new Error('User did not grant permissions');
	error.errorCode = 'permission';
	throw error;
	}
	launchCamera(options, callback);
	})
	.catch((error) => {
	/* Intercept the permission error as well as any other errors and call the callback
	* follow the same pattern expected for image picker results */
	callback({
	errorMessage: error.message,
	errorCode: error.errorCode || 'others',
	});
	});
	}

[AndrewGable]

Yeah I'll handle this 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0142d61bc15de5a06b

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

[mananjadhav]

@AndrewGable Been more than a few days since we've added an update. But curious, any specific reason we didn't set this External?

[AndrewGable]

It's a weekly issue so you can expect an update once a week. I introduced the bug so I want to fix it.

[mananjadhav]

thanks for the comment.

[AndrewGable]

Looking into if we can handle this via vision camera or not.

[tjferriss]

I'm not sure why the checklist didn't show up here. @mananjadhav can you please get started on this?

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• @mananjadhav The PR that introduced the bug has been identified. Link to the PR:
• @mananjadhav The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• @mananjadhav A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• @mananjadhav Determine if we should create a regression test for this bug.
• @mananjadhav If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• @mananjadhav Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[tjferriss]

@tienifr has been paid via Upworks. @mananjadhav can you please get started on the checklist?

[mananjadhav]

@tjferriss Can you please post a payment summary so that I can raise the payment request?

This was introduced when we added the component in this PR. This was a large PR and I think it was easy to miss the permissions. I've added a comment here.

I don't think we need any regression test here.

[tgolen]

Bump @tjferriss

[mananjadhav]

I also believe this is eligible for the timeline bonus? This was waiting for merge freeze but the C+ checklist was completed within the timeline.

[tjferriss]

I'm not sure it fits the timeline bonus, even with the feature freeze consideration. I see @tienifr was assigned on 8/26 and then I see your reviewer checklist comment on 9/1.

Payment Summary:

Reporter: NA
Contributor: @tienifr $1000
Contributor+: @mananjadhav $1000

[mananjadhav]

You're right @tjferriss. I don't know why I thought this was eligible. I just verified the assignment was on 8/26. Thanks for clarifying.

[tjferriss]

@mananjadhav have you raised the payment request?

[mananjadhav]

Yes @tjferriss I've done that.

[JmillsExpensify]

$1,000 payment approved for @mananjadhav based on BZ summary.

[tgolen]

Just waiting for payouts it looks like

[melvin-bot]

@tgolen, @AndrewGable, @mananjadhav, @tjferriss, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mananjadhav]

@tjferriss @tienifr can you confirm if the payout is done here?

[tienifr]

@tjferriss @tienifr can you confirm if the payout is done here?

It was for me. I'm not sure about others.

[mananjadhav]

@tjferriss @AndrewGable @tgolen I think we can close this one.

[tgolen]

OK, I'll go ahead and close it out.