Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-08-24] Payment for #22778 #24546

Closed
thienlnam opened this issue Aug 14, 2023 · 9 comments
Closed

[HOLD for payment 2023-08-24] Payment for #22778 #24546

thienlnam opened this issue Aug 14, 2023 · 9 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@thienlnam
Copy link
Contributor

#22778 was linked to an internal E/E issue.

Creating this App issue for C+ payment since one did not get created automatically

@thienlnam thienlnam added the Bug Something is broken. Auto assigns a BugZero manager. label Aug 14, 2023
@thienlnam thienlnam self-assigned this Aug 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 14, 2023

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Aug 14, 2023
@melvin-bot

This comment was marked as off-topic.

@thienlnam
Copy link
Contributor Author

Issue has not been deployed yet

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Aug 17, 2023
@melvin-bot melvin-bot bot changed the title Payment for #22778 [HOLD for payment 2023-08-24] Payment for #22778 Aug 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.54-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-08-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
  • [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
  • [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Aug 23, 2023
@johncschuster
Copy link
Contributor

Payment Summary

External issue reporter - NA
Contributor that fixed the issue - NA
Contributor+ that helped on the issue and/or PR - @Santhosh-Sellavel - $1000 to be paid via NewDot

cc @JmillsExpensify

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 25, 2023
@johncschuster johncschuster added Weekly KSv2 and removed Daily KSv2 labels Aug 29, 2023
@melvin-bot melvin-bot bot removed the Overdue label Aug 29, 2023
@johncschuster
Copy link
Contributor

@JmillsExpensify bump on the payment above!

@Santhosh-Sellavel
Copy link
Collaborator

Requested on ND

@JmillsExpensify
Copy link

Reviewed the details for @Santhosh-Sellavel. $1,000 approved for payment via NewDot based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants