[HOLD for payment 2023-08-30] Re-render the ReportActionItem when transaction is deleted

[mountiny]

Following on this PR #24590, once we are going to switch from using IOU report actions for the transaction dat to transaction objects which should be done here #24345, we should stop hiding the MoneyRequestView as we do here but we should add transaction as props to the ReportActionItem and re-render when it changes. Deleted transaction is wiped from the onyx.

cc @dukenv0307

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0195265ecd3403c746
• Upwork Job ID: 1692289426335956992
• Last Price Increase: 2023-08-17

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[mountiny]

No need for design review here. sorry for the ping

[mountiny]

I will ask in Callstack or SWM channels if anyone wants to take this one

[luacmartins]

I can work on this one

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0195265ecd3403c746

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

[luacmartins]

PR up - #25435

[JmillsExpensify]

Nice, I see that PR was merged!

[luacmartins]

Yes, should go to prod in today's deploy

[Pujan92]

@luacmartins @mountiny Seems regression https://expensify.slack.com/archives/C049HHMV9SM/p1692729074593069 from this PR as comment structure inconsistency after edit money request.

For newly request money we are making the. comment structure as an object here

App/src/libs/TransactionUtils.js

Line 55 in 1ec5bf4

const commentJSON = {comment};

But on the edit money request we received the comment as a string in the api onyx response and that makes the inconsistency.

[luacmartins]

I think this has already been fixed here already

[Pujan92]

Seems to reproduce with the open report response.

Screen.Recording.2023-08-25.at.01.22.13.mp4

[luacmartins]

We're currently refactoring this command. I'll check again once those PRs have been deployed

[luacmartins]

The App PR was deployed to prod 2 days ago. Updating the title with the payment date.

[garrettmknight]

@luacmartins could this be causing #26205 as well?

[luacmartins]

No, I don't think that issue is related to this.

[CortneyOfstad]

So according to this SO @eVoloshchak gets paid via eChat. Has payment been received? If not, please let me know and we can get that bumped. TIA!

[eVoloshchak]

@CortneyOfstad, I just requested the payment via NewDot, thanks!

[CortneyOfstad]

@eVoloshchak just confirming if the payment was successful or not? If so, we can close this out 👍

[JmillsExpensify]

@CortneyOfstad This is missing a payment summary. I need that before I can pay via NewDot.

[CortneyOfstad]

From what I can see, Eugene was assigned to the issue on 8/17. It shows that the PR went into production on 8/22, but it shows that a QA delayed the PR going into production, so while they did not qualify for the bonus, they would not receive the penalty.

Payment due: $1000 to @eVoloshchak

CC @JmillsExpensify

[CortneyOfstad]

@JmillsExpensify @eVoloshchak was payment confirmed in NewDot? Just checking to see if this can be closed — thanks!

[eVoloshchak]

@CortneyOfstad, it wasn't confirmed yet, but I requested it, I think the issue can be closed (we can open it back again if needed)

[JmillsExpensify]

$1,000 payment for @eVoloshchak approved based on BZ summary.

[CortneyOfstad]

Looks good to close! Thanks everyone!