[HOLD for payment 2023-09-21] Web - Inconsistency bug: Home equivalent of spanish first letter is not capital on 'Hmm its not here page'

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings->workspaces->any workspace->settings
3. Remove last 's' from URL to trigger 'Hmm its not here page', eg link:
4. https://staging.new.expensify.com/workspace/148AB979666D2030/setting
5. Observe that when language is english, it display 'Home' in 'Go back to Home page' with capital H
6. Change language to spanish and follow same steps, observe that spanish equivalent of 'Home' does not have capital H

Expected Result:

App should either display 'Home' in 'Go back to Home page' link in english with small 'h' or should display its equivalent in spanish in capital

Actual Result:

App displays 'Home' in 'Go back to Home page' link in english with capital 'H' and displays its equivalent in spanish in small letters

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.54-11

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

6180663847819167821small_h_for_home_equivalent_in_spanish.MP4

Recording.1220.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691301214398869

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01949489296e056716
• Upwork Job ID: 1694377206281830400
• Last Price Increase: 2023-08-23

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistency bug: Home equivalent of spanish first letter is not capital on Hmm its not here page

What is the root cause of that problem?

the translated value of goBackHome for word "Home" is capital for english and small for spanish.

What changes do you think we should make in order to solve the problem?

we need to change the translated value of goBackHome in spanish to be

// goBackHome: 'Volver a la página principal',
goBackHome: 'Volver a la Página principal',

What alternative solutions did you explore? (Optional)

we need to change the translated value of goBackHome in english to be

// goBackHome: 'Go back to Home page',
goBackHome: 'Go back to home page',

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistency bug: Home equivalent of Spanish first letter is not capital on 'Hmm its not here page'

What is the root cause of that problem?

The translation of goBackHome is inconsistency, principal and Home should be consistent capitalization

App/src/languages/es.js

Line 862 in 8e799df

goBackHome: 'Volver a la página principal',

App/src/languages/en.js

Line 858 in 8e799df

goBackHome: 'Go back to Home page',

What changes do you think we should make in order to solve the problem?

Home is the name of a page, so it should be capitalized. We should change goBackHome in Spanish to Volver a la página Principal

App/src/languages/es.js

Line 862 in 8e799df

goBackHome: 'Volver a la página principal',

What alternative solutions did you explore? (Optional)

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@mallenexpensify Huh... This is 4 days overdue. Who can take care of this?

[mallenexpensify]

Checking on internally
https://expensify.slack.com/archives/C01SKUP7QR0/p1692803899286019

[laurenreidexpensify]

I will do this next week

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01949489296e056716

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @jjcoffee (Internal)

[laurenreidexpensify]

I haven't had a chance to do this yet, will work on this on Friday

[melvin-bot]

@laurenreidexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@laurenreidexpensify Huh... This is 4 days overdue. Who can take care of this?

[laurenreidexpensify]

Merged 🎉

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update en.js: 'Home page' to 'home page' #26671

If no regressions arise, payment will be issued on 2023-09-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @dhanashree-sawant requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [] The PR that introduced the bug has been identified. Link to the PR:
• [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [] Determine if we should create a regression test for this bug.
• [] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[laurenreidexpensify]

No payments - i wrote the PR and @Julesssss reviewed it for me.

[dhanashree-sawant]

Hi @laurenreidexpensify, reporting bonus is left for this job

[mallenexpensify]

@dhanashree-sawant can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01fd1fae383a9df360

[dhanashree-sawant]

Thanks @mallenexpensify, I have accepted the offer.

[mallenexpensify]

Issue reporter: @dhanashree-sawant paid $250 via Upwork

👋