Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAB -> New Chat creates chat room between users though one room was already created by splitting bill #24651

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 16, 2023 · 4 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 16, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Create new account (userA).
  2. Create workspace and invite 2 users (userB and userC).
  3. As userA, click FAB -> Split Bill
  4. Input any amount more than 0.01 and click Next
  5. Select userB, userC and click Next
  6. Click Split
  7. Click Fab -> New Chat
  8. Select userB or userC.
  9. In opened report send any message
  10. You will get error "Unexpected error while posting the comment, please try again laterReport no longer exists"

Expected Result:

After split bill requested userA already has chat rooms with userB and userC. When userA clicks FAB -> New chat with userA or userB existing chat room should be opened

Actual Result:

Existing chat room was not opened. Instead that new room (dead room) was created

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.53.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

new-chat-caused-error.mp4
Recording.5834.mp4

Expensify/Expensify Issue URL:

Issue reported by: @mkarkachov

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691235322553369

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@uafrontender
Copy link
Contributor

I am the reporter of this issue and I have just tried to reproduce issue but unsuccessfully. I think it was fixed by this PR #22778

@twisterdotcom
Copy link
Contributor

I think we'll likely just need to close this then, as it seems like we already had a fix in the works when the report came in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants