Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEED TO PAY + COMPLETE CHECKLIST][TS migration] Migrate 'EmojiUtils.js' lib to TypeScript #24899

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 13 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/EmojiUtils.js 9
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@BartoszGrajdek
Copy link
Contributor

Hey! I’m Bartosz from Software Mansion, an expert agency, and I’d like to work on this issue!

@situchan
Copy link
Contributor

situchan commented Nov 7, 2023

🎀 👀 🎀

Copy link
Author

melvin-bot bot commented Nov 7, 2023

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@roryabraham roryabraham moved this from Todo to In Progress in Typescript migration Nov 8, 2023
@francoisl
Copy link
Contributor

PR is merged and on production - this is done.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Typescript migration Nov 23, 2023
@situchan
Copy link
Contributor

@francoisl can you please reopen the issue and add Bug label for payment? Thanks

@garrettmknight garrettmknight added the Bug Something is broken. Auto assigns a BugZero manager. label Nov 27, 2023
Copy link
Author

melvin-bot bot commented Nov 27, 2023

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 27, 2023
Copy link
Author

melvin-bot bot commented Nov 27, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@jliexpensify
Copy link
Contributor

jliexpensify commented Nov 28, 2023

I reviewed the PR and wanted to open the conversation on what was fair here - it looks like @situchan too this over from Miroslav, but there were delays in approvals and regressions involved. So there should be some penalties here, but at the same time, it looks like there were a number of issues being addressed.

Payment Summary

Upworks Job

@jliexpensify jliexpensify changed the title [TS migration] Migrate 'EmojiUtils.js' lib to TypeScript [NEED TO PAY + COMPLETE CHECKLIST][TS migration] Migrate 'EmojiUtils.js' lib to TypeScript Nov 28, 2023
@situchan
Copy link
Contributor

There were no regressions after PR was merged.
I took over on Oct 26 and merged on Nov 7
So no penalty applies to me

@situchan
Copy link
Contributor

This is neither bug nor new feature so BZ checklist not applies here

@jliexpensify
Copy link
Contributor

Great, thanks for weighing in - will create the Upworks job now and pay shortly.

@jliexpensify
Copy link
Contributor

Paid and job closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

5 participants