Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate 'PersonalDetails.js' lib to TypeScript #24909

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 11 comments
Closed

[TS migration] Migrate 'PersonalDetails.js' lib to TypeScript #24909

melvin-bot bot opened this issue Aug 16, 2023 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/actions/PersonalDetails.js 11
Issue OwnerCurrent Issue Owner: @mallenexpensify
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@fabioh8010
Copy link
Contributor

Hi, I'm Fábio from Callstack - expert contributor group - and I would like to take a look at this issue.

Copy link
Author

melvin-bot bot commented Nov 3, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@situchan
Copy link
Contributor

situchan commented Nov 6, 2023

🎀 👀 🎀 to get engineer for PR review

Copy link
Author

melvin-bot bot commented Nov 6, 2023

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@roryabraham roryabraham moved this from Todo to In Progress in Typescript migration Nov 8, 2023
@situchan
Copy link
Contributor

@cristipaval can you please add Bug label for payment? Thanks

@cristipaval cristipaval added the Bug Something is broken. Auto assigns a BugZero manager. label Nov 28, 2023
Copy link
Author

melvin-bot bot commented Nov 28, 2023

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Nov 28, 2023
Copy link
Author

melvin-bot bot commented Nov 28, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@cristipaval
Copy link
Contributor

@mallenexpensify , @situchan helped with the testing of this PR opened for this issue. Could you please issue the payment here?

@mallenexpensify
Copy link
Contributor

@situchan can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~0133368621a1725025

@mallenexpensify mallenexpensify removed the Reviewing Has a PR in review label Nov 28, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 1, 2023
@mallenexpensify
Copy link
Contributor

Contributor+: @situchan paid $250 via Upwork

Thanks for the help!

@melvin-bot melvin-bot bot removed the Overdue label Dec 1, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Typescript migration Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

4 participants