Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-11-01] [TS migration] Migrate 'Session' lib to TypeScript #24929

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 12 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/actions/Session/updateSessionAuthTokens.js 2
src/libs/actions/Session/index.js 26
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Oct 13, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 22, 2023

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 25, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'Session' lib to TypeScript [HOLD for payment 2023-11-01] [TS migration] Migrate 'Session' lib to TypeScript Oct 25, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 25, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 25, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 25, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.90-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@aimane-chnaif
Copy link
Contributor

@roryabraham can you please reopen and add Bug label for payment?

@roryabraham roryabraham reopened this Nov 11, 2023
@roryabraham roryabraham added NewFeature Something to build that is a new item. and removed Task labels Nov 11, 2023
Copy link
Author

melvin-bot bot commented Nov 11, 2023

@roryabraham
Copy link
Contributor

New Feature as this is R&D and has different accounting treatment

@roryabraham
Copy link
Contributor

roryabraham commented Nov 11, 2023

@sakluger just $250 to @aimane-chnaif for C+ TypeScript PR review

@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2023
@sakluger
Copy link
Contributor

@aimane-chnaif here's the upwork job: https://www.upwork.com/jobs/~01da62d5b68334261f

Please let me know once you've accepted the offer. Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Nov 20, 2023
@sakluger sakluger added Daily KSv2 and removed Weekly KSv2 labels Nov 20, 2023
@aimane-chnaif
Copy link
Contributor

@sakluger accepted, thanks!

@sakluger
Copy link
Contributor

Thanks! All paid 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Typescript Migration
Projects
Development

No branches or pull requests

5 participants