Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Awaiting payment 21st Nov] [TS migration] Migrate 'SafeAreaConsumer.js' component to TypeScript #24981

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 13 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/SafeAreaConsumer.js 4
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

@abdulrahuman5196
Copy link
Contributor

abdulrahuman5196 commented Nov 2, 2023

@roryabraham / @hayata-suenaga Could you kindly assign me here for C+ review?

Copy link
Author

melvin-bot bot commented Nov 2, 2023

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@abdulrahuman5196
Copy link
Contributor

@hayata-suenaga Could you kindly add bug label for BZ assignment to process the C+ payment here.

Melvin bot didn't update this issue automatically. Seems its due for payment processing today - #29755 (comment)

No checklist for migration PR.

@hayata-suenaga hayata-suenaga added the Bug Something is broken. Auto assigns a BugZero manager. label Nov 17, 2023
Copy link
Author

melvin-bot bot commented Nov 17, 2023

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 17, 2023
Copy link
Author

melvin-bot bot commented Nov 17, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@trjExpensify
Copy link
Contributor

@abdulrahuman5196 can you remind me the C+ review price for TS migration issues?

@trjExpensify trjExpensify changed the title [TS migration] Migrate 'SafeAreaConsumer.js' component to TypeScript [Awaiting payment 21st Nov] [TS migration] Migrate 'SafeAreaConsumer.js' component to TypeScript Nov 21, 2023
@abdulrahuman5196
Copy link
Contributor

@trjExpensify 250$ for migration PRs

@hayata-suenaga
Copy link
Contributor

yes that's right!

@trjExpensify
Copy link
Contributor

Cool, offer sent!

@abdulrahuman5196
Copy link
Contributor

Accepted the offer.

@trjExpensify
Copy link
Contributor

Paid!

@github-project-automation github-project-automation bot moved this from In Progress to Done in Typescript migration Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

4 participants