Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [HOLD for payment 2023-12-14] [TS migration] Migrate 'FormSubmit' component to TypeScript #25069

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/FormSubmit/index.native.js 3
src/components/FormSubmit/index.js 7
src/components/FormSubmit/formSubmitPropTypes.js 2
Issue OwnerCurrent Issue Owner: @michaelhaxhiu
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f6257533ccaffbde
  • Upwork Job ID: 1736828057092374528
  • Last Price Increase: 2023-12-18
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@pasyukevich
Copy link
Member

Hi,
I'm Eugene from Callstack - an expert contributor group
I’d like to work on this issue

Copy link
Author

melvin-bot bot commented Dec 3, 2023

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@mountiny mountiny added the Bug Something is broken. Auto assigns a BugZero manager. label Dec 14, 2023
Copy link
Author

melvin-bot bot commented Dec 14, 2023

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Dec 14, 2023
@mountiny mountiny assigned getusha and unassigned michaelhaxhiu Dec 14, 2023
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Dec 14, 2023
Copy link
Author

melvin-bot bot commented Dec 14, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Sorry, something went wrong.

@mountiny mountiny added Weekly KSv2 and removed Bug Something is broken. Auto assigns a BugZero manager. labels Dec 14, 2023
@mountiny mountiny added the Awaiting Payment Auto-added when associated PR is deployed to production label Dec 14, 2023
@mountiny mountiny changed the title [TS migration] Migrate 'FormSubmit' component to TypeScript [HOLD for payment 2023-12-14] [TS migration] Migrate 'FormSubmit' component to TypeScript Dec 14, 2023
@mountiny mountiny removed Reviewing Has a PR in review Weekly KSv2 labels Dec 14, 2023
Copy link
Author

melvin-bot bot commented Dec 18, 2023

@michaelhaxhiu, @srikarparsi, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Dec 18, 2023
@srikarparsi
Copy link
Contributor

Hi @michaelhaxhiu, I believe you need to pay @getusha $250 for reviewing the PR and we should be good to close out this issue :)

Copy link
Author

melvin-bot bot commented Dec 18, 2023

@michaelhaxhiu, @srikarparsi, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

@michaelhaxhiu michaelhaxhiu added the External Added to denote the issue can be worked on by a contributor label Dec 18, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-12-14] [TS migration] Migrate 'FormSubmit' component to TypeScript [$500] [HOLD for payment 2023-12-14] [TS migration] Migrate 'FormSubmit' component to TypeScript Dec 18, 2023
Copy link
Author

melvin-bot bot commented Dec 18, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01f6257533ccaffbde

@michaelhaxhiu michaelhaxhiu removed the External Added to denote the issue can be worked on by a contributor label Dec 18, 2023
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 18, 2023
Copy link
Author

melvin-bot bot commented Dec 18, 2023

Current assignee @getusha is eligible for the External assigner, not assigning anyone new.

@michaelhaxhiu
Copy link
Contributor

@getusha invited you to the job!

@melvin-bot melvin-bot bot removed the Overdue label Dec 18, 2023
@Ekaterina-Kaschenko
Copy link

  1. Create a types file in the root of FormSubmit component.
  2. Define public and private interfaces/types in the types file and export the public ones for external use.
  3. Use the .ts extension for each file in the folders.
  4. Go through each file and apply appropriate types for incoming parameters (props).
  5. Specify types for generics where needed.
  6. Test all properly.

Copy link
Author

melvin-bot bot commented Dec 18, 2023

📣 @Ekaterina-Kaschenko! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

6 participants