Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-06] [TS migration] Migrate 'AutoCompleteSuggestions' component to TypeScript #25093

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Not a priority Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/AutoCompleteSuggestions/index.native.js 3
src/components/AutoCompleteSuggestions/index.js 4
src/components/AutoCompleteSuggestions/autoCompleteSuggestionsPropTypes.js 1
src/components/AutoCompleteSuggestions/BaseAutoCompleteSuggestions.js 8
Issue OwnerCurrent Issue Owner: @anmurali
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Nov 24, 2023
Copy link
Author

melvin-bot bot commented Nov 26, 2023

Triggered auto assignment to @MariaHCD, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@hoangzinh
Copy link
Contributor

Hi @MariaHCD, this issue is not processed payout yet. I have been assigned to review the PR #31065. Could you help to pull a BZ member and assign me to this issue as well? Thanks

@mountiny mountiny added the Bug Something is broken. Auto assigns a BugZero manager. label Nov 27, 2023
Copy link
Author

melvin-bot bot commented Nov 27, 2023

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@mountiny mountiny assigned hoangzinh and unassigned anmurali Nov 27, 2023
@mountiny mountiny reopened this Nov 27, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 29, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'AutoCompleteSuggestions' component to TypeScript [HOLD for payment 2023-12-06] [TS migration] Migrate 'AutoCompleteSuggestions' component to TypeScript Nov 29, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 29, 2023
Copy link
Author

melvin-bot bot commented Nov 29, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Nov 29, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 Daily KSv2 labels Dec 5, 2023
@MariaHCD
Copy link
Contributor

@anmurali I believe we just need the payment for @hoangzinh here.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 11, 2023
@anmurali
Copy link

Sent offer here @hoangzinh

@melvin-bot melvin-bot bot removed the Overdue label Dec 13, 2023
@hoangzinh
Copy link
Contributor

@anmurali TS migration issue is only 250$ #24966 (comment). Can you check and send me another offer? Thanks

@anmurali
Copy link

@hoangzinh fixed the amount.

@hoangzinh
Copy link
Contributor

Applied thanks @anmurali

Copy link
Author

melvin-bot bot commented Dec 18, 2023

@hoangzinh, @MariaHCD, @anmurali, @VickyStash Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Dec 18, 2023
Copy link
Author

melvin-bot bot commented Dec 18, 2023

@hoangzinh, @MariaHCD, @anmurali, @VickyStash Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@anmurali
Copy link

Paid.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Dec 19, 2023
@melvin-bot melvin-bot bot removed the Overdue label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Not a priority Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

5 participants