Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-31] [TS migration] Migrate 'OptionsList' component to TypeScript #25129

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Not a priority Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/OptionsList/optionsListPropTypes.js 4
src/components/OptionsList/index.native.js 4
src/components/OptionsList/index.js 7
src/components/OptionsList/BaseOptionsList.js 11
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@kosmydel
Copy link
Contributor

kosmydel commented Jan 3, 2024

Hey! I’m Jakub from Software Mansion, an expert agency, and I’d like to work on this issue!

Copy link
Author

melvin-bot bot commented Jan 16, 2024

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added NewFeature Something to build that is a new item. Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 22, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'OptionsList' component to TypeScript [HOLD for payment 2024-01-31] [TS migration] Migrate 'OptionsList' component to TypeScript Jan 24, 2024
Copy link
Author

melvin-bot bot commented Jan 24, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@youssef-lr] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 30, 2024
Copy link
Author

melvin-bot bot commented Jan 31, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@sobitneupane
Copy link
Contributor

@youssef-lr I reviewed the associated PR. Can you please assign me the PR? I will require payment summary to request payment.

@melvin-bot melvin-bot bot added the Overdue label Feb 1, 2024
Copy link
Author

melvin-bot bot commented Feb 2, 2024

@youssef-lr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link
Author

melvin-bot bot commented Feb 6, 2024

@youssef-lr Still overdue 6 days?! Let's take care of this!

@youssef-lr
Copy link
Contributor

Sorry @sobitneupane I really thought I had already assigned you before. Just did now.

@melvin-bot melvin-bot bot added the Overdue label Feb 9, 2024
Copy link
Author

melvin-bot bot commented Feb 13, 2024

@youssef-lr, @sobitneupane Eep! 4 days overdue now. Issues have feelings too...

@youssef-lr
Copy link
Contributor

@sobitneupane anything you need from me here?

@melvin-bot melvin-bot bot removed the Overdue label Feb 14, 2024
@JmillsExpensify
Copy link

I need a payment summary to issue payment.

@melvin-bot melvin-bot bot added the Overdue label Feb 16, 2024
Copy link
Author

melvin-bot bot commented Feb 19, 2024

@youssef-lr, @sobitneupane Eep! 4 days overdue now. Issues have feelings too...

@youssef-lr
Copy link
Contributor

Payment summary

Contributor+: @sobitneupane owed $250 via NewDot.

The PR author and other reviewers are from an agency.

@melvin-bot melvin-bot bot removed the Overdue label Feb 19, 2024
@JmillsExpensify
Copy link

$250 approved for @sobitneupane based on summary above.

@melvin-bot melvin-bot bot added the Overdue label Feb 21, 2024
@youssef-lr
Copy link
Contributor

Not overdue.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 22, 2024
@youssef-lr
Copy link
Contributor

I think we're good to close here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Not a priority Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

4 participants