Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] [TS migration] Migrate 'NewTask' page to TypeScript #25213

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 31 comments
Closed

[$250] [TS migration] Migrate 'NewTask' page to TypeScript #25213

melvin-bot bot opened this issue Aug 17, 2023 · 31 comments
Assignees
@alexpensify @pasyukevich @c3024
Labels
External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023 •
edited
Loading

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/tasks/NewTaskTitlePage.js 18
src/pages/tasks/NewTaskPage.js 23
src/pages/tasks/NewTaskDetailsPage.js 18
src/pages/tasks/NewTaskDescriptionPage.js 18
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011d7e945e3d56a16e
  • Upwork Job ID: 1750844014325379072
  • Last Price Increase: 2024-01-26
  • Automatic offers:
    • c3024 | Contributor | 0
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Sep 11, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@fvlvte
Copy link
Contributor

fvlvte commented Jan 24, 2024

Hi, I'm Kacper from Callstack - expert contributor group - and I would like to take a look at this issue.

@melvin-bot melvin-bot bot added the Overdue label Jan 24, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 26, 2024
@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Jan 26, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'NewTask' page to TypeScript [$500] [TS migration] Migrate 'NewTask' page to TypeScript Jan 26, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 26, 2024

Job added to Upwork: https://www.upwork.com/jobs/~011d7e945e3d56a16e

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 26, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 26, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Jan 26, 2024
@ghost
Copy link

ghost commented Jan 26, 2024

Dibs

@mountiny mountiny removed Help Wanted Apply this label when an issue is open to proposals by contributors Not a priority labels Jan 26, 2024
@mountiny mountiny changed the title [$500] [TS migration] Migrate 'NewTask' page to TypeScript [$250] [TS migration] Migrate 'NewTask' page to TypeScript Jan 26, 2024
@alexpensify
Copy link
Contributor

No update

@fvlvte
Copy link
Contributor

fvlvte commented Feb 7, 2024

Hey, sorry, missed notification I was on another task, ll open draft today @alexpensify

@alexpensify
Copy link
Contributor

All good, thank you!

@alexpensify
Copy link
Contributor

Weekly Update: @fvlvte any news here? Thanks!

@fvlvte
Copy link
Contributor

fvlvte commented Feb 14, 2024

Hey, I got reassigned to another project so I think somebody from Callstack team will pick it over

@pasyukevich
Copy link
Contributor

Hi,
I'm Eugene from Callstack - an expert contributor group
I’d like to work on this issue

@hkopser99
Copy link
Contributor

Hey @alexpensify I just finished another TS migration job and would like to handle this one now. Looks like it's still unassigned but please let me know.

Proposal:

I would review current functionality and determine where these files are imported or otherwise used (e.g. via Routing). Once I understand their use I would amend their filenames to TS or TSX (where applicable) and amend the code in all four files to TS. I would then test them on all platforms and ensure no errors or changes in functionality are taking place prior to submitting PR for review.

@pasyukevich pasyukevich mentioned this issue Feb 20, 2024
Merged
50 tasks
@alexpensify alexpensify assigned pasyukevich and unassigned fvlvte Feb 21, 2024
@alexpensify
Copy link
Contributor

I'm catching up from being OOO and assigned @pasyukevich.

@thesahindia
Copy link
Member

I am planning to go OOO. Please reassign.

@thesahindia thesahindia removed their assignment Feb 21, 2024
@alexpensify
Copy link
Contributor

I asked for C+ help here:

https://expensify.slack.com/archives/C02NK2DQWUX/p1709073195364429

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Feb 27, 2024

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@alexpensify
Copy link
Contributor

@c3024 will be stepping in as the C+ here. Thanks!

@alexpensify
Copy link
Contributor

@pasyukevich - Any update here? Thanks!

@pasyukevich
Copy link
Contributor

@alexpensify PR was opened for review, waiting for a second review

@alexpensify
Copy link
Contributor

Awesome, thanks for the update.

@c3024 c3024 mentioned this issue Mar 6, 2024
Closed
@alexpensify
Copy link
Contributor

Thanks for the update, it looks like the review happened and we are moving forward here.

@alexpensify
Copy link
Contributor

Weekly Update: PR is in review

@c3024
Copy link
Contributor

c3024 commented Mar 15, 2024

Deployed to production. Automation hasn't triggered here.

@melvin-bot melvin-bot bot added the Overdue label Mar 25, 2024
@alexpensify
Copy link
Contributor

This looks like it slipped my payment review process, I need to review this one more tomorrow since we might be past the 7-day mark.

@melvin-bot melvin-bot bot removed the Overdue label Mar 25, 2024
@alexpensify
Copy link
Contributor

Here is the payment summary:

  • External issue reporter - N/A
  • Contributor that fixed the issue - @pasyukevich payments will be handled by the agency
  • Contributor+ that helped on the issue and/or PR - @c3024 $250

Upwork Job: https://www.upwork.com/jobs/~011d7e945e3d56a16e

*If applicable, the bonuses will be applied on the final payment

Extra Notes regarding payment: @c3024 - I've completed the payment process in Upwork. Sorry again for the delay here.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexpensify alexpensify

@pasyukevich pasyukevich

@c3024 c3024

Labels
External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Typescript Migration Weekly KSv2
Projects
No open projects
Typescript migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
7 participants
@alexpensify @fvlvte @pasyukevich @mountiny @thesahindia @c3024 @hkopser99