[$250] [TS migration] Migrate 'SettingsProfileContacts' page to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/pages/settings/Profile/Contacts/NewContactMethodPage.js	23
src/pages/settings/Profile/Contacts/ContactMethodsPage.js	23
src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js	28
src/pages/settings/Profile/Contacts/ValidateCodeForm/index.js	2
src/pages/settings/Profile/Contacts/ValidateCodeForm/index.android.js	2
src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.js	24

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0198d8e8646d15d941
• Upwork Job ID: 1750845557262495744
• Last Price Increase: 2024-01-26
• Automatic offers:
• fedirjh | Reviewer | 28123442
• tienifr | Contributor | 28123443

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[ghost]

Dibs

[tienifr]

@mountiny dibs, I'm the first commenter on the thread

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0198d8e8646d15d941

[melvin-bot]

Triggered auto assignment to @kadiealexander (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot]

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

This issue has not been updated in over 15 days. @youssef-lr, @fedirjh, @kadiealexander, @tienifr eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[fedirjh]

PR was meged and it's on staging.

[tienifr]

Hi, I believe there was an increase in the scope of this issue. Specifically, ContactMethodDetailsPage was previously a class component and in order to migrate it to TS, we had no other ways but to migrate it to functional component first. In the past, we used to have separated functional migration issues. They required an extensive knowledge and efforts to complete and warranted commensurate compensation for contributors.

Considering the complexity of ContactMethodDetailsPage and the substantial efforts involved, it seems reasonable to align the bounty with our past practices of adjusting compensation for increased scope (here for example).

cc @kadiealexander @youssef-lr

[tienifr]

@kadiealexander PR on production 7 days ago. Melvin is malfunctioning and Monthly is still there so I think I need to quick bump you. Also please have a look at my above comment 🙏🙏

[tienifr]

@kadiealexander @youssef-lr Please check this.

[fedirjh]

@youssef-lr, could you please remove the Reviewing label and bump to Daily as payment is due? Thanks.

[youssef-lr]

@kadiealexander can you handle payments please?

[kadiealexander]

Payouts due:

• Contributor: $250 @fedirjh
• Contributor+: $250 @tienifr

Upwork job is here.