Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate 'GitUtilsTest.js' test to TypeScript #25273

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 7 comments
Closed

[TS migration] Migrate 'GitUtilsTest.js' test to TypeScript #25273

melvin-bot bot opened this issue Aug 17, 2023 · 7 comments
Assignees
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
tests/unit/GitUtilsTest.js 1
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@melvin-bot melvin-bot bot closed this as completed Feb 5, 2024
Copy link
Author

melvin-bot bot commented Feb 5, 2024

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@mountiny mountiny added NewFeature Something to build that is a new item. and removed Not a priority labels Feb 8, 2024
Copy link
Author

melvin-bot bot commented Feb 8, 2024

@mananjadhav
Copy link
Collaborator

mananjadhav commented Feb 19, 2024

@mountiny @mallenexpensify @flodnv Based on this comment I am going to approve the PR. But the PR contains 54 files updates with minor changes, does it need a C+ review?

@flodnv
Copy link
Contributor

flodnv commented Feb 19, 2024

I think 3 reviewers is enough

@mountiny
Copy link
Contributor

Yep I thin no need for C+, thanks @mananjadhav lots of changes are only because this got updated and then we generate other files when we build the GH actions.

@flodnv flodnv closed this as completed Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration Weekly KSv2
Projects
Development

No branches or pull requests

4 participants