Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate 'SidebarLinks.perf-test.js' test to TypeScript #25311

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 13 comments
Closed

[TS migration] Migrate 'SidebarLinks.perf-test.js' test to TypeScript #25311

melvin-bot bot opened this issue Aug 17, 2023 · 13 comments
Assignees
Labels
NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
tests/perf-test/SidebarLinks.perf-test.js 6
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@melvin-bot melvin-bot bot closed this as completed Feb 5, 2024
Copy link
Author

melvin-bot bot commented Feb 5, 2024

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@mountiny mountiny added NewFeature Something to build that is a new item. and removed Not a priority labels Feb 8, 2024
Copy link
Author

melvin-bot bot commented Feb 8, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Feb 8, 2024
@mountiny mountiny reopened this Feb 8, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 16, 2024
@kevinksullivan
Copy link
Contributor

@mountiny bumped ya elsewhere, but is there anything I should be doing here?

@melvin-bot melvin-bot bot removed the Overdue label Feb 21, 2024
@pac-guerreiro
Copy link
Contributor

I'm Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

@kevinksullivan
Copy link
Contributor

@pac-guerreiro any update here?

@mountiny
Copy link
Contributor

I will ask in slack

@pac-guerreiro
Copy link
Contributor

@kevinksullivan @mountiny

The PR had some issues that need handling on my part and internal confirmation from my team, but it should be ready for C+ review next week!

@mountiny
Copy link
Contributor

@pac-guerreiro thanks, what is your ETA for us now?

@pac-guerreiro
Copy link
Contributor

@mountiny Internal review is almost done! I'm trying to get this approved this week!

@youssef-lr
Copy link
Contributor

Can we close this?

@melvin-bot melvin-bot bot removed the Overdue label Apr 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 29, 2024
@kevinksullivan
Copy link
Contributor

looks like fix is on prod so I will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2
Projects
Development

No branches or pull requests

5 participants