Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS migration] Migrate 'UnreadIndicatorsTest.js' test to TypeScript #25330

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 11 comments
Closed

[TS migration] Migrate 'UnreadIndicatorsTest.js' test to TypeScript #25330

melvin-bot bot opened this issue Aug 17, 2023 · 11 comments
Assignees
@CortneyOfstad @JKobrynski
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
tests/ui/UnreadIndicatorsTest.js 25
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Sep 11, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@melvin-bot melvin-bot bot closed this as completed Feb 5, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Feb 5, 2024

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Feb 5, 2024
@mountiny mountiny added NewFeature Something to build that is a new item. and removed Not a priority labels Feb 8, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Feb 8, 2024

Triggered auto assignment to @CortneyOfstad (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Feb 8, 2024
@mountiny mountiny reopened this Feb 8, 2024
@CortneyOfstad CortneyOfstad added Monthly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors and removed Weekly KSv2 labels Feb 14, 2024
@CortneyOfstad
Copy link
Contributor

Per Vit, SM and CS have their own process to prioritize these issues, so going to keep as monthly until someone takes them on 👍

@JKobrynski
Copy link
Contributor

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue.

@CortneyOfstad
Copy link
Contributor

Sounds good @JKobrynski!

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 28, 2024
@CortneyOfstad CortneyOfstad added Weekly KSv2 and removed Monthly KSv2 labels Feb 28, 2024
@JKobrynski JKobrynski mentioned this issue Mar 1, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Mar 7, 2024
@JKobrynski
Copy link
Contributor

The PR is ready for review!

@CortneyOfstad
Copy link
Contributor

Movement on the PR a few hours ago, so all looking good!

@CortneyOfstad
Copy link
Contributor

Deployed to staging 18 hours ago 🎉

@CortneyOfstad
Copy link
Contributor

deployed to production 2 days ago! Will keep this open until the 7-day period is over just in case there are any regressions 👍

@CortneyOfstad
Copy link
Contributor

No regressions so this is all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CortneyOfstad CortneyOfstad

@JKobrynski JKobrynski

Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration Weekly KSv2
Projects
No open projects
Typescript migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CortneyOfstad @mountiny @JKobrynski