Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-upgrade desktop #255

Closed
quinthar opened this issue Aug 19, 2020 · 3 comments · Fixed by #359
Closed

Auto-upgrade desktop #255

quinthar opened this issue Aug 19, 2020 · 3 comments · Fixed by #359
Assignees

Comments

@quinthar
Copy link
Contributor

Installing the mobile/desktop app is bit of a burden. Yes, we want mobile to auto-upgrade, but that's not really a RN risk -- we know how to do that (and just need to do it). But we haven't proven how to auto-upgrade desktop.

@quinthar quinthar added this to the Complete Proof of Concept milestone Aug 19, 2020
@AndrewGable AndrewGable self-assigned this Aug 19, 2020
@AndrewGable
Copy link
Contributor

It looks like there are two options:

  1. electron-builder - We currently use this to build the electron app and it is very well supported by the community. It has auto updater functionality built in, and works with s3 (where we host our current app), in addition to bare metal servers.
  2. autoUpdater (more information) - Which is maintained by electron, but the issue here is that in order to not use another library, we will have to have a public GitHub release, which I am not sure we want to maintain.

I personally think electron-builder is a clear winner here, but let me know if you disagree.


The first step to both of these is to sign the app with valid certificates, so I will begin investigating that process first.

@AndrewGable
Copy link
Contributor

I got the signatures working locally and confirmed in slack with the help of @kadiealexander and @chiragsalian that it doesn't require any System preferences changes so we are correctly signing and notarizing 👍

I will work on making these changes to the GitHub action, then dive into electron-builder.

@quinthar quinthar added HIGH and removed CRITICAL labels Aug 22, 2020
This was referenced Aug 31, 2020
@AndrewGable
Copy link
Contributor

PR sent for auto updating desktop versions 📤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants