Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Prevent potential duplication of adding the event listeners #25775

Closed
stitesExpensify opened this issue Aug 23, 2023 · 32 comments
Closed
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2

Comments

@stitesExpensify
Copy link
Contributor

stitesExpensify commented Aug 23, 2023

#19263 (comment)

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01240734a875b0971d
  • Upwork Job ID: 1694369600595484672
  • Last Price Increase: 2023-09-13
@stitesExpensify stitesExpensify added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 23, 2023
@melvin-bot melvin-bot bot changed the title Prevent potential duplication of adding the event listeners [$1000] Prevent potential duplication of adding the event listeners Aug 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 23, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01240734a875b0971d

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 23, 2023

Triggered auto assignment to @johncschuster (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 23, 2023

Current assignee @0xmiroslav is eligible for the External assigner, not assigning anyone new.

@stitesExpensify
Copy link
Contributor Author

@johncschuster this issue was already fixed here #22991 but we didn't have an issue for it. We just need to pay out @0xmiroslav for his role as C+

@melvin-bot
Copy link

melvin-bot bot commented Aug 23, 2023

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 23, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@Benjamin0427
Copy link

I have checked your job posting on Upwork.
I don't know exactly where this issue occurs, but I think this will help you a little.
https://stackoverflow.com/questions/45723205/removing-duplicate-event-listeners

@melvin-bot
Copy link

melvin-bot bot commented Aug 23, 2023

📣 @Benjamin0427! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@Benjamin0427
Copy link

My email was: benjamin940427@gmail.com
upwork profile link : https://www.upwork.com/freelancers/~014a23163be9779d19

@MitchExpensify
Copy link
Contributor

Un-assiging myself as John is on BZ too and got lucky first 😄 (Happy to take if I'm missing something though!)

@johncschuster
Copy link
Contributor

Payment Summary:

External issue reporter - NA
Contributor that fixed the issue - NA
Contributor+ member who reviewed the PR - @0xmiroslav - $1000 via Manual Request

cc @JmillsExpensify

@0xmiros
Copy link
Contributor

0xmiros commented Aug 26, 2023

@melvin-bot melvin-bot bot added the Overdue label Aug 28, 2023
@stitesExpensify
Copy link
Contributor Author

bump @johncschuster

@johncschuster
Copy link
Contributor

Thanks for the bump! I'll get payment issued now.

@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 12, 2023

@johncschuster, @stitesExpensify, @0xmiroslav Huh... This is 4 days overdue. Who can take care of this?

@0xmiros
Copy link
Contributor

0xmiros commented Sep 12, 2023

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Sep 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 13, 2023

@johncschuster @stitesExpensify @0xmiroslav this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@melvin-bot
Copy link

melvin-bot bot commented Sep 13, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@johncschuster
Copy link
Contributor

Not overdue. We're just working on payment.

@melvin-bot melvin-bot bot added the Overdue label Sep 18, 2023
@stitesExpensify
Copy link
Contributor Author

Same ^

@melvin-bot melvin-bot bot removed the Overdue label Sep 19, 2023
@stitesExpensify stitesExpensify added Weekly KSv2 and removed Daily KSv2 labels Sep 19, 2023
@johncschuster johncschuster added the Daily KSv2 label Sep 19, 2023
@johncschuster
Copy link
Contributor

Getting on the same page, here.

@melvin-bot
Copy link

melvin-bot bot commented Sep 20, 2023

@johncschuster @stitesExpensify @0xmiroslav this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

  • Decide whether any proposals currently meet our guidelines and can be approved as-is today
  • If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@melvin-bot melvin-bot bot added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Sep 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 20, 2023

Current assignee @0xmiroslav is eligible for the Internal assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Overdue label Sep 22, 2023
@stitesExpensify stitesExpensify removed the Daily KSv2 label Sep 25, 2023
@stitesExpensify
Copy link
Contributor Author

not overdue

@melvin-bot melvin-bot bot removed the Overdue label Sep 25, 2023
@stitesExpensify stitesExpensify added Monthly KSv2 and removed Weekly KSv2 labels Sep 25, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 26, 2023
@johncschuster
Copy link
Contributor

@0xmiroslav I'm going to close this issue. Can you please reopen it and ping me as soon as you're ready to accept payment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants