Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU - Unable to empty the merchant field to set it to default value 'Request' #26287

Closed
2 of 6 tasks
lanitochka17 opened this issue Aug 30, 2023 · 4 comments
Closed
2 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 30, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify,com
  2. Create a money request with custom merchant
  3. Open IOU report
  4. Click on the merchant
  5. Empty the merchant
  6. Save the merchant

Expected Result:

The merchant is defaulted to 'Request' when it is emptied

Actual Result:

The merchant is not defaulted to 'Request'. It is defauled to data that is set in Step 2
The behavior here is that it defaults to whatever data that is entered in the Merchant field when the IOU is created. But what if I need to delete the Merchant and change it back to default (Request), it does not allow me to set it back to 'Request'

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome
  • MacOS / Desktop

Version Number: 1.3.59-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6182657_20230830_201332.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Aug 30, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2023

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mountiny mountiny removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Aug 30, 2023
@mountiny
Copy link
Contributor

@lanitochka17 This is not a bug, this is intended behaviour

  1. The merchant cannot be empty
  2. when you set the Merchant at first, that is the default merchant (Request is not default merchant for that particular expense anymore)
  3. Resetting it will go to the initially inserted merchant
  • you can just type Request if you want it to be Request

@lanitochka17
Copy link
Author

@mountiny Thank you for the clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants