-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web - The Cursor displayed as enabled when hovering over the amount, description, merchant, or date for the paid request money. #26441
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @tgolen ( |
ProposalPlease re-state the problem that we are trying to solve in this issue. What is the root cause of that problem?This is coming from this PR What changes do you think we should make in order to solve the problem?Option 1We need to add Option 2We can only show the disabled cursor without greying the text, like we do with complete tasks. Option 3If we don't want to grey out text and don't want to show the disabled cursor, we can pass FocusScreen.Recording.2023-09-01.at.3.28.57.AM.mov |
I don't think this is a blocker. There's no functionality impacted here and it's a small cursor UI thing. |
IMO the way we have here is better, so I think we should do nothing, but I'll let @shawnborton chime in here. |
Triggered auto assignment to @mallenexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
@luacmartins, we can show the disabled cursor without greying the text. We do same for the completed task and I think we should be consistent with that. Screen.Recording.2023-09-01.at.3.44.49.AM.mov |
Yea, I know we can. I just dislike the disabled cursor haha but then again, that's up to design |
@luacmartins, yeah, that's what I meant, whatever the design is, we should be consistent. |
@luacmartins, we will have one more issue if we do not disable it, it will be focusable using tab/f11 key. |
Bumping this to Daily per Carlo's comment
Also from Carlos
I'm not sure I 100% grasp the bug. I'm assuming it's that the cursor shows like this |
Triggered auto assignment to @kevinksullivan ( |
Bug0 Triage Checklist (Main S/O)
|
@kevinksullivan I'm off this week, can you please keep 👀 on this then I'll snag it back on Monday? Thx |
I'm a little lost on this one but cc'ing @mountiny here - I think having these rows display as disabled was a mistake, and thus we want to revert them to appear like read-only push-to-page rows (with no caret) and thus we don't need a disabled cursor. |
Yeah I dont understand this, we did have disabled and that was temporary and its fixed, now it looks normal, there is no hover effect, no change in cursor and no chevron so its clear you cannot clicked. This is intentional and not a bug Screen.Recording.2023-09-06.at.18.02.14.mov |
@mountiny, we also need set Should I create a separate issue for this? Monosnap.screencast.2023-09-06.20-34-32.mp4 |
@Krishna2323 yeah this issue as far as I can see from the title is not about tasks, thanks! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The Cursor should display as disabled when hovering over the amount, description, merchant, or date for the paid request money.
Actual Result:
The Cursor displayed as enabled when hovering over the amount, description, merchant, or date for the paid request money.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.60.1
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screenshare.-.2023-09-01.12_22_45.AM.mp4
Recording.4145.mp4
Expensify/Expensify Issue URL:
Issue reported by: @misgana96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693516892936839
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: