Log in - Deeplinks to Desktop App don’t work with any browser

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open Desktop App
2. Enter a new account and press Continue
3. Copy the Magic link from validation email and change it to staging
4. Open a new tab and navigate to the staging magic link
5. Verify the user is prompted to open the desktop app

Expected Result:

The user can open the Desktop App using a deeplink from the browser

Actual Result:

No prompt to open Desktop App. Deeplinks to Desktop App don’t work with any browser

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.60-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6184302_Desktop-deeplinks-not-working.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Log in - Deeplinks to Desktop App don’t work with any browser

What is the root cause of that problem?

In this Deeplink wrapper component, we early exit if user is not authenticated yet

App/src/components/DeeplinkWrapper/index.website.js

Lines 82 to 83 in 5d88b4a

	// Navigation state is not set up yet, we're unsure if we should show the deep link prompt or not
	if (currentScreen === undefined || isAuthenticated === false) {

It's reason why if user is not authenticated, Web app won't show the prompt to open on Desktop app

What changes do you think we should make in order to solve the problem?

• We need to remove the condition isAuthenticated === false out of above condition. So we only check only Navigation state is not set up yet as it's described in the comment.

• Moreover, we need to remove this line too, otherwise App will be loop of set show/hide the Prompt when user is not authenticated yet.

  App/src/components/DeeplinkWrapper/index.website.js

  Line 53 in 5d88b4a

  setHasShownPrompt(false);

[pradeepmdk]

we already have this #25790

[melvin-bot]

@maddylewis Whoops! This issue is 2 days overdue. Let's get this updated quick!

[maddylewis]

closing as dupe/intended behavior - #25790 (comment)