[Distance] Distance - 'Use current location' does not invoke error message when clicked offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #25990

Action Performed:

1. Go to staging.new.expensify.com
2. Go to + > Request money > Distance
3. Go offline
4. Go to Start
5. Click Use current location

Expected Result:

The error message 'We were unable to find your location, please try again or enter an address manually' shows up

Actual Result:

No error message shows up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.61-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6184841_bandicam_2023-09-01_17-37-36-040.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[pecanoro]

Looking!

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Use current location does not invoke error message when offline.

What is the root cause of that problem?

We have not set a timeout when making a geo location request.

What changes do you think we should make in order to solve the problem?

We just need to set a timeout option here.

ie Replace getCurrentPosition(onSuccess, onError); with getCurrentPosition(onSuccess, onError, {timeout: 1000})

What alternative solutions did you explore? (Optional)

We can also prevent the request by checking if the user is offline in this function. If the user is offline, we can call onError function and set an appropriate error code.

[pecanoro]

Since the same PR caused a few blockers we are discussing internally if we should revert it and polish it before deploying it again.

[huzaifa-99]

I will be fixing this with a new PR (taking changes from #25990)

cc: @hayata-suenaga @narefyev91

[huzaifa-99]

Should we just hide the 'Use current location' button when offline @hayata-suenaga?

[pecanoro]

PR reverted here, so I am removing the deploy blocker label and I will let @huzaifa-99 handle it in the new PR.

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[hayata-suenaga]

@huzaifa-99 when you create the new PR, please link this issue to your PR so that this issue can be closed when your fix is deployed

[huzaifa-99]

Sure, I will do that very soon @hayata-suenaga

[Christinadobrzyn]

Hey @huzaifa-99 this issue seems similar although it involves typing an address instead of "current location" but do you think the fix will be the same?

[huzaifa-99]

Hi @Christinadobrzyn.

I believe the issue you mentioned is different (has a different RCA/fix).

[hayata-suenaga]

@Christinadobrzyn the issue you linked is different from this one 🙇

[melvin-bot]

This issue has not been updated in over 15 days. @pecanoro, @huzaifa-99 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[hayata-suenaga]

@huzaifa-99 can you confirm that this issue was fixed after your second PR was deployed?

[huzaifa-99]

@hayata-suenaga yes, it's fixed. We disable the 'use current location' button in offline mode.

[hayata-suenaga]

this issue was reported by applause and doesn't involve payment to any party. Closing this