[Hold#15212][$500] Chat -The " new message" is not shown on top of the page after mark as unread an IOU

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on a report with IOU conversation
3. Long press the IOU conversation
4. Tap Mark as Unread
5. Scroll up the page to note " new message"
6. Long press any text message
7. Tap Mark as Unread
8. Scroll up the page

Expected Result:

After marking as unread an IOU, if user mark as unread any text message and scrolls up, the " new message" must be shown on top of the page

Actual Result:

After marking as unread an IOU, if user mark as unread any text message and scrolls up, the " new message" is not shown on top of the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.63-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6188699_iou.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bbc84cf35cbe2835
• Upwork Job ID: 1699077904760467456
• Last Price Increase: 2023-09-05

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[rmm-fl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After marking a post as unread, and then scrolling up the "new messages" floating text is show and marking another post as unread the "new messages" floating text is dimissed and scrolling up again doesn't bring it back.

What is the root cause of that problem?

App/src/pages/home/report/ReportActionsList.js

Lines 286 to 289 in 6b1a667

	<FloatingMessageCounter
	isActive={isFloatingMessageCounterVisible && !!currentUnreadMarker.current}
	onClick={scrollToBottomAndMarkReportAsRead}
	/>

The condition for isActive depends on if there is a current marker and before the current marker changes, current marker is being reset to null for a second. Which results in isActive being false, and dismissing the "new messages" button.

What changes do you think we should make in order to solve the problem?

App/src/pages/home/report/ReportActionsList.js

Lines 286 to 289 in 6b1a667

	<FloatingMessageCounter
	isActive={isFloatingMessageCounterVisible && !!currentUnreadMarker.current}
	onClick={scrollToBottomAndMarkReportAsRead}
	/>

Remove !!currentUnreadMarker.current from isActive as the scroll handlers already check for !!currentUnreadMarker.current here lazily while scrolling here:

App/src/pages/home/report/ReportActionsList.js

Lines 182 to 194 in 6b1a667

	const handleUnreadFloatingButton = () => {
	if (scrollingVerticalOffset.current > VERTICAL_OFFSET_THRESHOLD && !isFloatingMessageCounterVisible && !!currentUnreadMarker.current) {
	setIsFloatingMessageCounterVisible(true);
	}
	if (scrollingVerticalOffset.current < VERTICAL_OFFSET_THRESHOLD && isFloatingMessageCounterVisible) {
	if (readActionSkipped.current) {
	readActionSkipped.current = false;
	Report.readNewestAction(report.reportID);
	}
	setIsFloatingMessageCounterVisible(false);
	}
	};

And it works - thanks to the preconditions already present, for example: isFloatingMessageCounterVisible is initialized false, so it doesn't result in "new messages" being show when report is opened.

Result

result.mp4

What alternative solutions did you explore? (Optional)

--

[slafortune]

bug report looks good

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bbc84cf35cbe2835

[melvin-bot]

Current assignee @slafortune is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[rmm-fl]

Probably on hold for #15212

[slafortune]

Thanks @rmm-fl

[slafortune]

assigning a new BZ member, I am out on sabbatical

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

@eVoloshchak, @sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

[sonialiap]

Still on hold for #15212

[sonialiap]

Still on hold for #15212

[sonialiap]

PR not live yet, will test after it's out #25935

[MonilBhavsar]

This issue should be fixed! We can retest and most probably close it

[sonialiap]

I cannot reproduce, I think this is fixed, closing