Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [HOLD for payment 2023-11-21] [Tracking] Start using DotLottie animation assets instead of lottie JSON #26857

Closed
roryabraham opened this issue Sep 6, 2023 · 23 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Sep 6, 2023

Problem

We are scaling up our use of lottie animations across our app. However, lottie JSON files are large and heavy. For example, we've seen performance issues with the lounge page animation, which is about 4Mb.

Solution

Let's adopt the new dotlottie file format for our lottie animations to save on bundle size, make animations load faster on web, and make them more lightweight to run. It's likely that the new file format will result in files about 10% the size of the current ones.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01177ccd6f38fa029b
  • Upwork Job ID: 1729581933567508480
  • Last Price Increase: 2023-11-28
Issue OwnerCurrent Issue Owner: @mananjadhav
@roryabraham roryabraham added Weekly KSv2 Planning Changes still in the thought process labels Sep 6, 2023
@roryabraham roryabraham self-assigned this Sep 6, 2023
@roryabraham
Copy link
Contributor Author

Fortunately lottie-react-native now supports dotlottie 🎉

The next step is to just get our web implementation in place. Posted about this in slack here

@roryabraham
Copy link
Contributor Author

#26871

@melvin-bot melvin-bot bot added the Overdue label Sep 15, 2023
@roryabraham
Copy link
Contributor Author

Pinged for updates in #26871

@melvin-bot melvin-bot bot removed the Overdue label Sep 19, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 27, 2023
@roryabraham
Copy link
Contributor Author

@kosmydel has a draft PR against the upstream but is OOO this week. I'm also working with Emilio and Matin to make sure they're paid for their work in lottie-react-native for iOS and Android

@roryabraham
Copy link
Contributor Author

Pinged for an update in the lottie web task. Working on paying lottie-react-native maintainers for their work in adding DotLottie support.

@melvin-bot melvin-bot bot removed the Overdue label Oct 12, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 20, 2023
@roryabraham
Copy link
Contributor Author

Web support PR was approved three days ago

@roryabraham
Copy link
Contributor Author

I see there's a draft PR, left a review on it to request that we first implement web support for lottie in one PR, then follow up with another to switch to .lottie files

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Weekly KSv2 labels Oct 30, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 7, 2023
@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 21, 2023
Copy link

melvin-bot bot commented Nov 24, 2023

@roryabraham Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Nov 24, 2023
Copy link

melvin-bot bot commented Nov 28, 2023

@roryabraham 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@roryabraham
Copy link
Contributor Author

This is done but we need to make a C+ payment to @mananjadhav, marking as New Feature to move arrange that.

@melvin-bot melvin-bot bot removed the Overdue label Nov 28, 2023
@roryabraham roryabraham added NewFeature Something to build that is a new item. and removed Planning Changes still in the thought process labels Nov 28, 2023
Copy link

melvin-bot bot commented Nov 28, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Nov 28, 2023
@roryabraham roryabraham added the External Added to denote the issue can be worked on by a contributor label Nov 28, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-11-21] [Tracking] Start using DotLottie animation assets instead of lottie JSON [$500] [HOLD for payment 2023-11-21] [Tracking] Start using DotLottie animation assets instead of lottie JSON Nov 28, 2023
Copy link

melvin-bot bot commented Nov 28, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01177ccd6f38fa029b

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 28, 2023
Copy link

melvin-bot bot commented Nov 28, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 28, 2023
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 28, 2023
Copy link

melvin-bot bot commented Nov 28, 2023

📣 @mananjadhav Please request via NewDot manual requests for the Contributor Contributor+ role ($500)

@AndriyKas
Copy link

Actually, yes, DotLottie player should help you, but not 100%.
There is a high probability that the person who created this Lottie file optimized it in the program in which they created it.
Let me just take a look at what your files look like and what file size they have

I am a motion designer with a skill in web development and have already solved about 10 similar problems related to lottie optimization

Copy link

melvin-bot bot commented Nov 28, 2023

📣 @AndriyKas! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@mananjadhav
Copy link
Collaborator

I've raised a request on NewDot for the same.

@NicMendonca
Copy link
Contributor

BZ summary:

  • reporter: n/a
  • contributor: n/a
  • contributor +: @mananjadhav - $500

@JmillsExpensify
Copy link

$500 payment approved for @mananjadhav based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

6 participants