[$500] Web - Visiting wrong description/merchant link displays blank RHN

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Click on plus and click request money
3. Enter any amount and select any user and complete the process
4. Open the request money page by clicking twice on request money message
5. Click on description/merchant and copy the link
6. Paste it into any report and modify the report by adding or removing any character eg: if link is: https://staging.new.expensify.com/r/1758292653775719/edit/description , modify it like this https://staging.new.expensify.com/r/1758292653775719/edit/descriptions
7. Send the modified link
8. Open the link and observe that it displays blank RHN

Expected Result:

App should not have any link which will take the user to blank RHN or any blank page

Actual Result:

Description/merchant edit link if modified and visited then it displays blank RHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.65.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Offline.description.update.issue.request.money.mov

Recording.4300.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693680596106879

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01047be634d7f302b0
• Upwork Job ID: 1699809692585758721
• Last Price Increase: 2023-09-07

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We're showing a blank screen for non-existing edit request routes.

What is the root cause of that problem?

We're returning null if no route is matched here.

What changes do you think we should make in order to solve the problem?

We need to return a NotFound screen instead of null here.

Note
This might be an issue with tasks or other RHP screens as well. It would be better to check them along with this ticket. I think that can be handled in the PR!

Result

Screen.Recording.2023-09-06.at.11.52.41.PM.mov

What alternative solutions did you explore? (Optional)

Instead of having all kind of requests in a single Page, we can also create separate them into there own pages so that the StackNavigator shows a NotFound page automatically.

[zanyrenney]

Able to reproduce - adding external label.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01047be634d7f302b0

[melvin-bot]

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[dukenv0307]

This will be fixed here #26269

[allroundexperts]

Yep. I can confirm its a dupe. Thanks for pointing this out @dukenv0307!

@zanyrenney Let's close this.

[zanyrenney]

ah great, thank you @dukenv0307 thanks @allroundexperts too.