Web - Unable to edit legal business name after adding it

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the website
2. Go to Settings > Workspace
3. Select a workspace from the list
4. Click bank account
5. Click connect manually
6. Pass step 1 by filling in the information
7. Pass step 2 by filling in all required information
8. Click the back button from step 3 and go to step 2
9. Try to edit the legal business name

Expected Result:

Able to edit legal business name

Actual Result:

Unable to edit legal business name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.65.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screenshare.-.2023-09-01.9_57_40.PM.1.mp4

20230907_002639.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @misgana96

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693594590742959

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[BhuvaneshPatil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to edit legal business name after adding it, similar happens with tax id number

What is the root cause of that problem?

we are setting disabled prop to equal in case we have company name. But look wise it is same. That's why user doesn't know if the input is disabled or not.

What changes do you think we should make in order to solve the problem?

• We can add disabled style in case we pass the prop disabled here -
  

  App/src/components/TextInput/index.js

  Line 64 in d60c13e

  inputStyle={[styles.baseTextInput, styles.textInputDesktop, isLabeledMultiline ? styles.textInputMultiline : {}, ...props.inputStyle]}

we can add inputDisabled style conditionally if we are passing disabled as true.

inputStyle={[styles.baseTextInput, styles.textInputDesktop, isLabeledMultiline ? styles.textInputMultiline : {}, ...props.inputStyle, props.disabled ? styles.inputDisabled : {}]}

It will look something like -

What alternative solutions did you explore? (Optional)

[alitoshmatov]

I think there is a purpose on disabling these inputs. And it looks similar to #25577 where disabled input is not obvious to the user, and will be solved in this PR #25991

[puneetlath]

Thanks for that @alitoshmatov. I'm going to go ahead and close this then, as it seems like we don't want these fields to be editable. Feel free to comment if you disagree or if I've misunderstood!