[HOLD for payment 2023-10-10] [$1000] Android - Request money - IOU SmartScan disappears from the history when a user is relogged

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open New Expensify app
2. Log in with any login
3. Navigate to the WS room, if you don't have one, create one.
4. In the Action menu select Request money
5. Select the Scan tab
6. Add any image
7. Complete the request
8. Re-login as the same user
9. Navigate to the room from step 3

Expected Result:

The SmartScan money request should not disappear from the history when the user logs in again and should eventually complete its work and provide the user with the processed result.

Actual Result:

Request money SmartScan disappears from the history when a user is relogged.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.65-2

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6191017_Record_SmartScan_disappears.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0153f8948debd26069
• Upwork Job ID: 1705016851186573312
• Last Price Increase: 2023-09-29
• Automatic offers:
• s77rt | Reviewer | 26956018
• shubham1206agra | Contributor | 26956019

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!

[stephanieelliott]

Hm, I'm not able to repro this, the request persists after I log out and log back in. @izarutskaya can you see this is still reproducible for you?

Here is an image from Mac/Safari:

[izarutskaya]

@stephanieelliott Sorry for waiting, now I can't repro this in Chrome, but I still can repro this in Android App.
Build - v1.3.70-5

Screen.Recording.20230915.223032.New.Expensify.mp4

[melvin-bot]

@stephanieelliott Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@stephanieelliott Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@stephanieelliott this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[stephanieelliott]

Just tried reproing again, resolved on all other platforms but still happening in Android native.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0153f8948debd26069

[melvin-bot]

Current assignee @stephanieelliott is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot]

@s77rt, @stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[s77rt]

Not overdue. Looking for proposals

[melvin-bot]

@s77rt @stephanieelliott this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[aimane-chnaif]

This should have been assigned to @s-alves10 as they submitted proposal first in older issue.

[aimane-chnaif]

Context: #26700 (comment)

[shubham1206agra]

@aimane-chnaif But this is a separate issue with the same RCA. And I didn't know about this proposal either.
And we have already done the work in the PR.

[melvin-bot]

🎯 ⚡️ Woah @s77rt / @shubham1206agra, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @shubham1206agra got assigned: 2023-09-30 13:09:53 Z
• when the PR got merged: 2023-10-01 23:25:06 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix readFileAsync to extract type also for file upload #28533

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment offer (Reviewer)
• @shubham1206agra requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: Accept receipt in request money #23770
• The offending PR has been commented on: Accept receipt in request money #23770 (comment)
• A discussion in #expensify-bugs has been started: https://expensify.slack.com/archives/C049HHMV9SM/p1696440597637729
• Determine if we should create a regression test for this bug: No

[stephanieelliott]

Summarizing payment on this issue:

• Issue reporter: N/A
• Contributor: @shubham1206agra $1500 ($1000 bounty + $500 bonus), paid via Upwork
• Contributor+: @s77rt $1500 ($1000 bounty + $500 bonus), paid via Upwork

Upwork job is here, 50% bonus is included on final payout

Everyone is paid, thanks!