Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for Payment: 2023-12-21 ] [$500] Web - App displays empty value when sending 3 backtick code block in single backtick code block #26966

Closed
1 of 6 tasks
kbecciv opened this issue Sep 7, 2023 · 83 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Sep 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Open any report
  3. Send text in following format : (```Test```)
  4. Observe that it displays empty value for some time after sending the message
  5. Again edit the message and change the format back to: (```Test```)
  6. Save and observe that now it does not display the text until we revisit the report

Expected Result:

App should display the message as it is after sending and after editing

Actual Result:

App displays empty message on sending the message in specific format for some time and using same format in edit displays empty text until report is revisited

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.65.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

specific.format.text.empty.1.mp4
Recording.4312.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693741353234359

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010fc0553d7b989f1b
  • Upwork Job ID: 1704043272417964032
  • Last Price Increase: 2023-10-03
  • Automatic offers:
    • akamefi202 | Contributor | 27749619
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@samh-nl
Copy link
Contributor

samh-nl commented Sep 7, 2023

Cannot reproduce when using staging BE (but can without).

@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@dylanexpensify
Copy link
Contributor

Coming back from conference last week - updating today!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 11, 2023
@dylanexpensify
Copy link
Contributor

unable to repro - @dhanashree-sawant @kbecciv can you confirm

@melvin-bot melvin-bot bot removed the Overdue label Sep 13, 2023
@dhanashree-sawant
Copy link

Able to reproduce on v1.3.69-1 staging, let me know the text you are using, I can help to understand what could be missing or different

2023-09-14.11-11-12.mp4

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 18, 2023
@dylanexpensify
Copy link
Contributor

Confirmed!

@dylanexpensify dylanexpensify added the External Added to denote the issue can be worked on by a contributor label Sep 19, 2023
@melvin-bot melvin-bot bot changed the title Web - App displays empty value when sending 3 backtick code block in single backtick code block [$500] Web - App displays empty value when sending 3 backtick code block in single backtick code block Sep 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~010fc0553d7b989f1b

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2023

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2023

📣 @agilejune! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@melvin-bot
Copy link

melvin-bot bot commented Sep 21, 2023

@ArekChr @dylanexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Sep 21, 2023
@dylanexpensify
Copy link
Contributor

no proposals yet!

@akamefi202
Copy link
Contributor

I created a PR in expensify-common repo. Please review it.

@dylanexpensify
Copy link
Contributor

bump @ArekChr ^

@akamefi202
Copy link
Contributor

@MonilBhavsar Could you please review soon if you have any time for it?

@MonilBhavsar
Copy link
Contributor

Done!

@melvin-bot melvin-bot bot added the Overdue label Nov 24, 2023
@MonilBhavsar MonilBhavsar added the Reviewing Has a PR in review label Nov 27, 2023
@melvin-bot melvin-bot bot removed the Overdue label Nov 27, 2023
@MonilBhavsar
Copy link
Contributor

PR is in review Expensify/expensify-common#607
@ArekChr if you could please take a look

@ArekChr
Copy link
Contributor

ArekChr commented Nov 28, 2023

Sorry for delay, I will take a look @MonilBhavsar

@dylanexpensify
Copy link
Contributor

Any update @ArekChr

@ArekChr
Copy link
Contributor

ArekChr commented Dec 6, 2023

Hi @dylanexpensify, the PR is still undergoing review. We are actively discussing and testing the PR.

@dylanexpensify
Copy link
Contributor

@ArekChr mind giving us a rough ETA on this one? TY! 🙇‍♂️

@akamefi202
Copy link
Contributor

@dylanexpensify @ArekChr
#32639
PR merge is paused because of license/snyk test. Could you please let me know what I can do to fix this?

@akamefi202 akamefi202 mentioned this issue Dec 11, 2023
47 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Dec 11, 2023
@akamefi202
Copy link
Contributor

#32639
@dylanexpensify @ArekChr @MonilBhavsar PR is merged finally.

@akamefi202
Copy link
Contributor

@ArekChr @MonilBhavsar Could you please update status of this issue to hold?

@dylanexpensify dylanexpensify changed the title [$500] Web - App displays empty value when sending 3 backtick code block in single backtick code block [HOLD for Payment: 2023-12-21 ] [$500] Web - App displays empty value when sending 3 backtick code block in single backtick code block Dec 19, 2023
@dylanexpensify
Copy link
Contributor

tomorrow!

@dylanexpensify
Copy link
Contributor

dylanexpensify commented Dec 21, 2023

Payment summary:

Please apply!

@dylanexpensify
Copy link
Contributor

@dhanashree-sawant please apply here!

@dhanashree-sawant
Copy link

Thanks @dylanexpensify, I have applied to the job.

@dylanexpensify
Copy link
Contributor

offer sent @dhanashree-sawant !

@dylanexpensify
Copy link
Contributor

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants