Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] PR:26447 Web - Task, IOU - Reports are archived when task is completed and IOU is paid #27012

Closed
1 of 6 tasks
izarutskaya opened this issue Sep 8, 2023 · 11 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@izarutskaya
Copy link

izarutskaya commented Sep 8, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Precondition: User has a task assigned to themselves and IOU requested from another user.

  1. Go to https://26447.pr-testing.expensify.com/
  2. Open task report.
  3. Click Mark as done.
  4. Open IOU report.
  5. Click Pay elsewhere.

Expected Result:

When task report is completed and IOU is paid, each respective report will not be archived.

Actual Result:

When task report is completed and IOU is paid, each respective report is archived.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.64-2 PR:26447

Reproducible in staging?: N

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6191931_bandicam_2023-09-08_04-11-09-207.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01df504b8b7e62cf60
  • Upwork Job ID: 1702486310040948736
  • Last Price Increase: 2023-09-15
@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 8, 2023

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 8, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@izarutskaya
Copy link
Author

Found when validating PR : #26447

@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@alexpensify
Copy link
Contributor

Still on my testing list

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 11, 2023
@alexpensify alexpensify added the External Added to denote the issue can be worked on by a contributor label Sep 15, 2023
@melvin-bot melvin-bot bot changed the title PR:26447 Web - Task, IOU - Reports are archived when task is completed and IOU is paid [$500] PR:26447 Web - Task, IOU - Reports are archived when task is completed and IOU is paid Sep 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01df504b8b7e62cf60

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2023

Current assignee @alexpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@alexpensify
Copy link
Contributor

Waiting for proposals here

@melvin-bot melvin-bot bot removed the Overdue label Sep 15, 2023
@parasharrajat
Copy link
Member

parasharrajat commented Sep 15, 2023

@alexpensify We will be solving these issues in the PR:26447 itself, If I am not mistaken.

These should not be exported.

@parasharrajat
Copy link
Member

@izarutskaya I tried to reproduce this on #26447

  1. Task moved to archived on completion: Not Reproduced
  2. Paying IOU: Not Reproduced
Screenshot 2023-09-15 at 7 08 42 PM

@alexpensify
Copy link
Contributor

Ok, with this feedback, I'm going to close out. I thought that the PR didn't include this fix, and was broken into it's on GH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

3 participants